Comments (3)
If self.socket is None, that's because the 'disconnect' method was called, probably due to an error on the socket in DCCConnection.process_data. Unfortunately, the nature of the error is discarded, so the first step is going to be to add some logging there.
Original comment by: Jason R. Coombs
from irc.
After further investigation, and based on your report, I believe the issue arises when more than 16k of data is sent without a newline in a DCC Chat session, it triggers a disconnect (with a non-helpful "Bad peer! Naughty peer!" comment in the code). In 576fd2d6df26, I've added some logging when that occurs that might at least verify my suspicion that this is the cause.
Can you run with the latest (unreleased) IRC code and see if your server reports a log message when that occurs?
I'm not sure why there's a 16k limit on messages. Maybe it's part of the spec or maybe the author just assumed a 16k limit, so even if you confirm this is the cause, more investigation will need to be done to better understand the rationale.
Original comment by: Jason R. Coombs
from irc.
I'm unable to replicate the issue, so with no follow-up response, I'm closing this issue. If you have additional detail or can help me replicate the issue, please do add more detail and I will gladly re-open.
Original comment by: Jason R. Coombs
from irc.
Related Issues (20)
- The internals still rely on VERSION_STRING HOT 2
- How to cleanly stop a reactor? HOT 2
- why do I get this error when using Pidgin client for connecting to IRC? ERROR :Closing Link: c-66-31-107-137.hsd1.ma.comcast.net (*** Banned ) HOT 1
- How to get connection log? HOT 3
- Add example on how to send a message to a channel HOT 1
- How can i print irc messages in my console?
- Disconnect issue HOT 1
- Implement default handler if nothing matches HOT 1
- [AIO] No client side ping-pong
- [AIO] Excess flood prevention HOT 3
- [AIO] Registering a connection needs to be split out of connect() HOT 1
- [AIO] Connection real_nickname must not be set before registration HOT 1
- [AIO] Implement SASL PLAIN with expect() flow
- High CPU usage in irc.server. HOT 1
- Add support for ignoring ssl validation in the examples HOT 2
- Add support for SASL HOT 4
- In tests DeprecationWarning no event loop
- ValueError when trying to download using DCC HOT 2
- Basic irc bot HOT 1
- DCC Transfers getting stuck HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irc.