client crashes on EINTR

[jaraco]

client crashes on EINTR

[jaraco]

It's not obvious to me that the right thing to do is simply suppress EINTR, though I'm not particularly familiar with when that signal would be raised or what the proper thing is to do in that case. However, since the release of 8.6, it's now possible to customize the Manifold class (formerly IRC class) and customize the process_forever behavior. Consider:

class RetryOnEINTRManifold(Manifold):
    def process_once(self, *args, **kwargs):
        """
        Override process once to suppress EINTR signals.
        """
        try:
            return super(RetryOnEINTRManifold, self).process_once(*args,
                **kwargs)
        except select.error as ex:
            if ex[0] != errno.EINTR:
                raise

ServerConnection.manifold_class = RetryOnEINTRManifold

Give that a try and let me know how it goes. If it works for you, but you still believe this behavior is something that all clients should expect, then please do provide some explanation or justification so we can have better documentation for the change.

---

Original comment by: Jason R. Coombs

[jaraco]

I'm going to mark this as resolved for now, but do please feel free to follow-up, especially if the workaround above does not work as prescribed.

---

Original comment by: Jason R. Coombs