Giter Site home page Giter Site logo

Comments (5)

jaraco avatar jaraco commented on May 28, 2024

That's a good point. Until very recently, that class was called "IRC" and instances of it were called "irclibobj", neither name which was helpful at all in describing the behavior.

I brainstormed alone and came up with Manifold because of the way it collected streams of data from different connections and handled them in a single place (the way a car manifold takes streams of air from the cylinders and combines them into a single exhaust).

I agree that Reactor would be better. Would you be willing to put together a pull request to include the changelog entry for a backward-incompatible release? Alternately, a blurb in the documentation may suffice.

seems to be global (?)

I'm not sure I follow. How is it global? What would prevent you from creating multiple Manifolds? I wouldn't recommend creating multiple, but I don't see anything that precludes doing so.


Original comment by: Jason R. Coombs

from irc.

jaraco avatar jaraco commented on May 28, 2024

Sorry, I was a bit irritated when I wrote the intial bug-report.

I'll spend some time moving stuff about, and renaming the manifold object, and get something together in the next few days.

Re: The global thing: You are correct, it's not global. I was a bit confused by the fact that the manifold class definition is assigned as a class member, and then the class member class definition is instantiated (this is presumably to allow monkey-patching the manifold object).


Original comment by: Fake Name

from irc.

jaraco avatar jaraco commented on May 28, 2024

There's also a few other tweaks I'd like to make with regard to the documentation, In particular, the fact that runtime class introspection is used to look up method names should be (in my opinion) made much more clear. I use SublimeCodeIntel for coding assistance, and the dynamic nature of the lookup mechanism makes any sort of method lookup completely useless. This, combined with the fact that the information that you can subscribe to any IRC method in the events.py file by prefixing it with on_ is barely documented, makes using the library a bit confusing.


Original comment by: Fake Name

from irc.

jaraco avatar jaraco commented on May 28, 2024

See https://bitbucket.org/jaraco/irc/pull-request/30/renamed-all-instances-of-the-manifold/diff


Original comment by: Fake Name

from irc.

jaraco avatar jaraco commented on May 28, 2024

Closed by accepted pull-request: https://bitbucket.org/jaraco/irc/pull-request/30/renamed-all-instances-of-the-manifold/diff

Thanks for letting me complain about terminology!


Original comment by: Fake Name

from irc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.