Comments (5)
That's a good point. Until very recently, that class was called "IRC" and instances of it were called "irclibobj", neither name which was helpful at all in describing the behavior.
I brainstormed alone and came up with Manifold because of the way it collected streams of data from different connections and handled them in a single place (the way a car manifold takes streams of air from the cylinders and combines them into a single exhaust).
I agree that Reactor would be better. Would you be willing to put together a pull request to include the changelog entry for a backward-incompatible release? Alternately, a blurb in the documentation may suffice.
seems to be global (?)
I'm not sure I follow. How is it global? What would prevent you from creating multiple Manifolds? I wouldn't recommend creating multiple, but I don't see anything that precludes doing so.
Original comment by: Jason R. Coombs
from irc.
Sorry, I was a bit irritated when I wrote the intial bug-report.
I'll spend some time moving stuff about, and renaming the manifold object, and get something together in the next few days.
Re: The global thing: You are correct, it's not global. I was a bit confused by the fact that the manifold class definition is assigned as a class member, and then the class member class definition is instantiated (this is presumably to allow monkey-patching the manifold object).
Original comment by: Fake Name
from irc.
There's also a few other tweaks I'd like to make with regard to the documentation, In particular, the fact that runtime class introspection is used to look up method names should be (in my opinion) made much more clear. I use SublimeCodeIntel for coding assistance, and the dynamic nature of the lookup mechanism makes any sort of method lookup completely useless. This, combined with the fact that the information that you can subscribe to any IRC method in the events.py
file by prefixing it with on_
is barely documented, makes using the library a bit confusing.
Original comment by: Fake Name
from irc.
See https://bitbucket.org/jaraco/irc/pull-request/30/renamed-all-instances-of-the-manifold/diff
Original comment by: Fake Name
from irc.
Closed by accepted pull-request: https://bitbucket.org/jaraco/irc/pull-request/30/renamed-all-instances-of-the-manifold/diff
Thanks for letting me complain about terminology!
Original comment by: Fake Name
from irc.
Related Issues (20)
- How to cleanly stop a reactor? HOT 2
- why do I get this error when using Pidgin client for connecting to IRC? ERROR :Closing Link: c-66-31-107-137.hsd1.ma.comcast.net (*** Banned ) HOT 1
- How to get connection log? HOT 3
- Add example on how to send a message to a channel HOT 1
- How can i print irc messages in my console?
- Disconnect issue HOT 1
- Implement default handler if nothing matches HOT 1
- [AIO] No client side ping-pong
- [AIO] Excess flood prevention HOT 3
- [AIO] Registering a connection needs to be split out of connect() HOT 1
- [AIO] Connection real_nickname must not be set before registration HOT 1
- [AIO] Implement SASL PLAIN with expect() flow
- High CPU usage in irc.server. HOT 1
- Add support for ignoring ssl validation in the examples HOT 2
- Add support for SASL HOT 4
- In tests DeprecationWarning no event loop
- ValueError when trying to download using DCC HOT 2
- Basic irc bot HOT 1
- DCC Transfers getting stuck HOT 1
- Test regressions: irc/dict.py::irc.dict.IRCDict, irc/strings.py::irc.strings.IRCFoldedCase
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irc.