Comments (3)
Looking briefly at the code, on_welcome will only be called if the server sends a 'welcome' event. I don't see any reason why the IRC client would not be dispatching that event if the server sent it. My suspicion is that the server isn't sending the welcome message, and that the behavior you describe is expected. It would be hard to tell, though, without an actual test case (or at least documentation indicating that we expect the welcome message from the server in all cases).
Here's what I recommend: write a small script (similar to testbot.py) that reproduces the issue with a public server (in a way that doesn't cause a nuisance), run that script to demonstrate that the issue exists, and then post that script here. From there, we can enable some debugging and determine if there's a failure in the library or if it's working as expected.
Original comment by: Jason R. Coombs
from irc.
You can close this. Ill send a pull request fixing this. :)
Original comment by: unconscious
from irc.
As written, this report appears invalid. At the very least, more detail is needed to demonstrate the issue. Feel free to re-open or send a pull request.
Original comment by: Jason R. Coombs
from irc.
Related Issues (20)
- Test regressions: irc/dict.py::irc.dict.IRCDict, irc/strings.py::irc.strings.IRCFoldedCase
- Example for creating multiple connections to a server? HOT 1
- After joining a channel, how do I get a list of usernames? HOT 1
- 'AioReactor' object has no attribute 'scheduler' HOT 3
- set_keepalive resulting into "irc.client.ServerNotConnectedError: Not connected."
- Empty quit message raises IndexError
- encoding outgoing messages seems to remove "\x1d" HOT 1
- Docs builds failing HOT 1
- IRCFoldedCase no longer folding HOT 1
- The addition of new numeric event names for SASL broke heisenbridge, which was using numeric codes. HOT 1
- SSL Support HOT 1
- `irc.connection.Factory.connect` should support `ssl.SSLContext.wrap_socket` with the `server_hostname` parameter HOT 1
- List channels HOT 2
- Error when attempting to join multiple channels HOT 2
- no colored or formatted text? HOT 4
- IRC Bot reconn strategy question HOT 2
- ResourceWarnings in test_reconnects_are_stable
- How to use data from one event handler in a different one?
- Receive public messages HOT 1
- SASL example
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irc.