Giter Site home page Giter Site logo

Comments (9)

DCzajkowski avatar DCzajkowski commented on May 21, 2024 7

@lexanth would you be willing to create a PR with your solution from df2f147? That would be very helpful for all people using this package in CI :)

from cypress-image-snapshot.

obartra avatar obartra commented on May 21, 2024 6

Yeah it would be really useful to have a flag (to use on CI) where if images are missing the tests fail but working locally (without a flag) it would create missing images

from cypress-image-snapshot.

Donaab avatar Donaab commented on May 21, 2024 1

Yes, this would be a very useful option ... and I think it should be default behavior: If you don't find the file to match fail the test. Then you can use the updateSnapshots=true option and update the screenshots locally.
@jaredpalmer Is there some option to add a quick fix for this?

from cypress-image-snapshot.

vladimirvolek avatar vladimirvolek commented on May 21, 2024 1

The library is ded.

from cypress-image-snapshot.

jackjocross avatar jackjocross commented on May 21, 2024

Interesting, not currently. Are you envisioning that at the end of your tests, if any snapshot files exist that were not compared on the run the test would fail?

from cypress-image-snapshot.

jackjocross avatar jackjocross commented on May 21, 2024

Cool, that makes sense. I think we might want to hook into Cypress' test:after:run event to perform these checks.

from cypress-image-snapshot.

devtreehouse avatar devtreehouse commented on May 21, 2024

Any update on this?

from cypress-image-snapshot.

axelboc avatar axelboc commented on May 21, 2024

I'm interested in this as well. I run Cypress in a CI environment, and I'd like to see a failure on my PRs when new snapshots are created. Two reasons:

  • I'd like to be notified that I need to check the new snapshot to make sure it looks as expected.
  • A new snapshot could indicate a regression (e.g. an unexpected change in the name of the snapshot, a test that runs when it should have been skipped, etc.)

from cypress-image-snapshot.

balassy avatar balassy commented on May 21, 2024

Hey Friends,
It seems that this feature is not yet implemented in this library. Is there any fork that has this feature?

from cypress-image-snapshot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.