Giter Site home page Giter Site logo

Comments (3)

jstewmon avatar jstewmon commented on June 3, 2024

@lukechilds I've tried to thoroughly explain the problem in sindresorhus/got#519 (comment).

I think cacheable-request intends to support the same interface as http.request based on the docs:

Request function to wrap with cache support. Should be http.request or a similar API compatible request function.

So, I'd like to fix this by formatting the cache key according to one of the supported argument types for http.request: string, URL or object.

We can still check for the cache-specific options as properties on a URL instance, but I'm not sure anyone would ever want to provide them that way. I'll work up a PR.

from cacheable.

jstewmon avatar jstewmon commented on June 3, 2024

I think this is closed by #43?

from cacheable.

sindresorhus avatar sindresorhus commented on June 3, 2024

Yup

from cacheable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.