Should ALLOW_UNKNOWN_TYPE_IN_RELATIONSHIP be less restrictive

[jsteinbrunner]

Should ALLOW_UNKNOWN_TYPE_IN_RELATIONSHIP be less restrictive

[iamareebjamal]

@Kevinrob Any library which requires you to extend your model classes must be avoided like plague

[Kevinrob]

I don't use this library anymore. We have switched to https://github.com/kamikat/moshi-jsonapi. 😉

[jsteinbrunner]

@jasminb
I wanted to follow up to get your thoughts. I'm happy to submit a PR with this change, but wanted to see if you agreed with this behavior before doing so.

[Kevinrob]

@Kevinrob Any library which requires you to extend your model classes must be avoided like plague

Yeah, it's a good point 😀 But jackson library is a pain for Android application (performance, size, etc...).

[jasminb]

@jsteinbrunner Please correct me if I'm wrong, you are saying that you have a case where client encounters completely unknown relationship field and the lib fails to ignore it?

[jsteinbrunner]

@jasminb
I'm embarrassed to admit that I may have created this issue when there isn't actually a problem. We identified this workflow, had seen the issue in the past on an earlier version, and looking through the code, I made a bad assumption that it still existed.

I apologize for not doing my due diligence and verifying the problem existed by writing a test against the latest version. I am unable to write a test now that reproduces the issue, and can see in the code why it now works. I will close this issue and if I discover something new in the future, I will let you know.

[jasminb]

@jsteinbrunner no problem at all.