Comments (7)
Done.
But I also think Jasmine can probably handle this transparently, by falling back to require()
when it gets that particular error code. The drawback I see is that it'd lead to more confusing errors if someone tries to use ES module syntax in a JSX file without transpiling, but hopefully that's a rare scenario.
from jasmine-npm.
Well, it didn't take long at all to get the answer to "do we still need the jsLoader
setting, and why?". One of the ways in which dynamic import isn't quite a drop-in replacement for require is that it only accepts paths that use a small predefined list of extensions, which doesn't include .jsx
.
I'm not sure how best to reconcile the conflict between providing good support for ES modules and supporting nonstandard (but very common) file extensions. But as a quick fix you can get around the problem by adding jsLoader": "require"
to your jasmine.json
file.
from jasmine-npm.
@sgravrock Darn, that sucks. I can confirm that jsLoader: "require"
fixes the problem.
Thanks for updating the docs in 1e133d6. Can I suggest updating the React documentation page here as well? Given that most React users will be following that guide I think the .jsx
info will be relevant to them there.
from jasmine-npm.
Thanks! Going to close this issue as this addresses my initial issue.
from jasmine-npm.
Thanks to you both for handling this issue promptly. It resolved the same issue for .coffee
files in coffeelib.
from jasmine-npm.
I've also just released 4.0.1, which handles this situation without the need for a configuration change.
from jasmine-npm.
Confirmed. With 4.0.1 jsx
files work without jsLoader: "require"
. Thanks!
from jasmine-npm.
Related Issues (20)
- jasmine flags, oneFailurePerSpec and stopSpecOnExpectationFailure don't work well HOT 2
- RFC: Well-defined public API HOT 1
- Failed to load reporter module jasmine 4.x HOT 1
- Jasmine loads test dependency as CommonJS module instead of ESM HOT 2
- Export Loader HOT 2
- getting an error jasmine.getEnv is not a function HOT 2
- Unable to find specs when using [email protected] HOT 2
- Consider using child_process.fork() to parallelize Jasmine runs HOT 28
- Jasmine 4 ES Modules / Dynamic Import Doesn't Work with Paths that Have Encoded Slashes HOT 4
- jasmine --helper flag broken following addHelperFiles() removal
- --reporter does not work with namespaced modules HOT 4
- Feature Request: Allow re-running test suites without restarting HOT 2
- Package subpath './lib/command.js' is not defined by "exports" using jasmine-xml-reporter HOT 1
- Vulnerabilities found on latest version of Jasmine(4.6.0) HOT 1
- Problem excluding files HOT 4
- Project base dirs containing special Glob syntax don't work HOT 1
- Regression in jasmine 5: settings bleed over to next `Jasmine` instance HOT 4
- `--require` fails with `runner.addRequires is not a function` in 5.x HOT 1
- Add a `--verbose` flag HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jasmine-npm.