Comments (2)
Hi Tim! Thanks for reaching out. I unfortunately have not used Require.js
or AMD modules extensively myself. Both of the code snippets that you are
showing look fine to me, however. I actually like the idea of setting the
ifvisible handler directly against the TimeMe object. I'll do a refactor
later, I think, to simply refer back to an ifvisible property set directly
on the TimeMe objec instead of executing the getIfVisibleHandle logic every
single time I need ifvisible.
I assume you'll be making a pull request. Let me know if I can help with
anything.
On Tue, Aug 18, 2015 at 10:46 PM, Tim Fletcher [email protected]
wrote:
I'm building and embeddable JS widget which has a requirement not to
inject any new global variable to the page. I'm using requireJS to do this
and importing TimeMe as a module. The import works, but because TimeMe
expects ifvisible to be available in the global scope, and it's isn't via
RequireJS, it can't initialize properly.I've made a couple of changes that I'd like to get your opinion on as I'm
not that familiar with AMD modules and requireJS.I've added ifvisible as a dependent module in define and set it as a
property (which I don't think I like):if (typeof define === "function" && define.amd) {
define(['ifvisible'], function(ifvisible) {
TimeMe.ifvisible = ifvisible;
return TimeMe;
});
} else {
window.TimeMe = TimeMe;
}and then detected this.ifvisible in getIfVisibleHandle to set the handle
correctly.getIfVisibleHandle: function(){
if (typeof ifvisible === 'object') {
return ifvisible;
else if (typeof this.ifvisible === 'object') {
return this.ifvisible;
} else {
if (typeof console !== "undefined") {
console.log("Required dependency (ifvisible.js) not found. Make sure it has been included.");
}
throw {
name: "MissingDependencyException",
message: "Required dependency (ifvisible.js) not found. Make sure it has been included."
};
}
},I think ideally i'd rewrite the class to have a constructor function and
pass in the dependency but it's a lot of changes. Interested to hear your
thoughts on this!—
Reply to this email directly or view it on GitHub
#14.
- Jason Christopher Zissman
from timeme.js.
Sure, I can submit a pull request. Will do shortly :)
from timeme.js.
Related Issues (20)
- Huge times HOT 6
- Not working correctly when user watches a video on a page HOT 5
- Timer needs to be reinitialized after being reset. How can I just set the timer to zero? HOT 2
- How to get appid? HOT 1
- Demo link http://timemejs.com/ is broken HOT 3
- Release version 2.1
- Still get this error: TypeError: Cannot read property 'length' of undefined
- Rewritten in TypeScript with leaner feature set: browser-interaction-time HOT 1
- Window event handlers
- How do you measure how long the person has been on the page? HOT 2
- Bug in your implementation Incorrect time tracked HOT 1
- How to get total time spent on multiple pages? HOT 2
- How to deal with embedded videos playing? HOT 4
- How would you save timing data (per pageview or session) to Google Analytics?
- idleTimeoutInSeconds -1
- Timer stops counting when leaving page even though trackWhenUserLeavesPage = false HOT 2
- Inaccurate Time Tracked when session is left for long hours
- TimeMe.trackTimeOnElement is not a function HOT 1
- Use of Pusher as the websocket receiver?
- getTimeOnCurrentPageInSeconds returns huge value
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from timeme.js.