org.javamoney:moneta:1.2 requires Java 9+?

[javamoney]

org.javamoney:moneta:1.2 requires Java 9+?

[keilw]

I'm afraid this must be a side-effect of using module-info in Java 9. The only way to get both is probably a multi-version-jar.

[atsticks]

The code is compiled first with Java 9 target including module descriptor. In a second run it is compiled with Java 8 overriding all Java 9 code, expect the module-info.class (which is exlucded). In the end you should have all in Java 8 format, but the module descriptor, which is ignored by Java 8. I suppose there was something going wrong. Nevertheless I have to build another version, since the module-info of the convert module is not at its correct location. Consquently it is not resolvable by downstream modules such as Javamoney libraries. So I will package a 1.2.1 release, wich should fix everything within the next hours, if somebody has time, I can wait with maven central synch and we can check things are in place beforehand in the bintray repos... Worked well for the API module already. Am So., 15. Apr. 2018 um 17:17 Uhr schrieb Werner Keil < [email protected]>:

…

I'm afraid this must be a side-effect of using module-info in Java 9. The only way to get both is probably a multi-version-jar. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#188 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC5sc_IT9LwPfy_pKqEmG9Ue8cauUenkks5to2SXgaJpZM4TVgEP> .

-- *Anatole Tresch* PPMC Member Apache Tamaya JCP Star Spec Lead *Switzerland, Europe Zurich, GMT+1* *maketechsimple.wordpress.com <http://maketechsimple.wordpress.com/> * *Twitter: @atsticks, @tamayaconf* *Speaking at:* [image: JSD_Speaker_2017][image: J-Con 2017 logo][image: JVM Con]

[keilw]

Are you sure, the API 1.0.2 works with Java 8? I was able to reproduce the problem building Moneta, so the API JAR could be based on the wrong JVM version, too.
The multi-release-jar plugin works perfectly fine but fails in Travis ;-/

[atsticks]

I was checking class versions before publishing it...Will recheck it... Am So., 15. Apr. 2018 um 20:55 Uhr schrieb Werner Keil < [email protected]>:

…

Are you sure, the API 1.0.2 works with Java 8? I was able to reproduce the problem building Moneta, so the API JAR could be based on the wrong JVM version, too. The multi-release-jar plugin works perfectly fine but fails in Travis ;-/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#188 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC5sc2yHCMP8XbMlyvVULO2P081shw-yks5to5exgaJpZM4TVgEP> .

-- *Anatole Tresch* PPMC Member Apache Tamaya JCP Star Spec Lead *Switzerland, Europe Zurich, GMT+1* *maketechsimple.wordpress.com <http://maketechsimple.wordpress.com/> * *Twitter: @atsticks, @tamayaconf* *Speaking at:* [image: JSD_Speaker_2017][image: J-Con 2017 logo][image: JVM Con]

[keilw]

Then it should be possible to build Moneta with Java 8, but right now it fails like

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.883 s
[INFO] Finished at: 2018-04-15T21:15:29+02:00
[INFO] Final Memory: 24M/252M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project moneta-core: Fatal error compiling: invalid flag: --module-path -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :moneta-core

[atsticks]

No there is only a requirement you can USE it with Java 8, not building. Building works as well, as long as you exclude the module-info.java file, see maven compiler settings. Am So., 15. Apr. 2018 um 21:23 Uhr schrieb Werner Keil < [email protected]>:

…

It should be possible to build Moneta with Java 8, but right now it fails like [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3.883 s [INFO] Finished at: 2018-04-15T21:15:29+02:00 [INFO] Final Memory: 24M/252M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project moneta-core: Fatal error compiling: invalid flag: --module-path -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :moneta-core — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#188 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC5sc1C1yau6IW89IpsHQ4U-sDMzy9okks5to54ggaJpZM4TVgEP> .

-- *Anatole Tresch* PPMC Member Apache Tamaya JCP Star Spec Lead *Switzerland, Europe Zurich, GMT+1* *maketechsimple.wordpress.com <http://maketechsimple.wordpress.com/> * *Twitter: @atsticks, @tamayaconf* *Speaking at:* [image: JSD_Speaker_2017][image: J-Con 2017 logo][image: JVM Con]

[keilw]

The examples are downstream use cases that should build with Java 8 for now.

[atsticks]

thats ok. I tested the current version creating a Java 8 based project, which use api/ri as a dependency. this obviously builds with java 8. So we are on the same page... Werner Keil <[email protected]> schrieb am Mo., 16. Apr. 2018, 02:17:

…

The examples are downstream use cases that should build with Java 8 for now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#188 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC5sc0JL6BHxFF8vvY-pHDXn6FOMxQbiks5to-MXgaJpZM4TVgEP> .

[keilw]

I could not verify with examples but now that both API and RI should be on JCenter or MavenCentral soon I can try. It felt better for the API because the build did not fail with a "Wrong class version" already.

At the very least when features like "value objects" in Java 11 or above become available, maybe Moneta more than the API seems a viable candidate for multi-version-jars, that is why I gave it a try. If the API can remain smaller for now that's good, but with the fast pace at which new JDK versions are poured onto the market now it seems inevitable we have to use something for multi-version-jars pretty soon.

[dominik42]

If you switch from 1.2 to 1.2.1 then it can be compiled with Java8 again

<groupId>org.javamoney</groupId>  
<artifactId>moneta</artifactId>  
<version>1.2.1</version>

[keilw]

Yes, I'd say we can close this with 1.2.1