Processing nested classes and their methods

[PELock]

Processing nested classes and their methods

[PELock]

Your code is invalid, still it treats the public void run() method as a member of outer class.

[PELock]

Is checking

if (node.getParentNode().isPresent() && node.getParentNode().get() == nodeClass)

in MethodVisitor a good way to do it?

[jlerbsc]

This is a design problem arising from the fact that you have nested 2 visitors and your code snippet has compilation errors.

The visitor you are using browses all the members of the class declaration or the included class is one of the members of the class. The solution would be to modify the visitor's behaviour so that it is only interested in method declarations or create your own visitor.

May be something like that

List<MethodDeclaration> methodDeclarationList = new ArrayList<>();

	 cu.accept(new VoidVisitorAdapter<List<MethodDeclaration>>()
        {
            // iterate class by class
            @Override
            public void visit(ClassOrInterfaceDeclaration nodeClass, List<MethodDeclaration> param)
			{
				System.out.println("CLASS = " + nodeClass.getNameAsString());

				List<MethodDeclaration> methodDeclarations = nodeClass.findAll(MethodDeclaration.class);
				methodDeclarations.forEach(md -> visit(md.asMethodDeclaration(), param));

				// random order
				Collections.shuffle(methodDeclarationList);
				// reset index
				Count index = new Count();

				// insert shuffled methods one by one
				methodDeclarations.forEach(md -> {
					md.replace(param.get(index.compteur));
					index.incr();
				});

				param.clear();

				nodeClass.getMembers().stream()
				.filter(member -> member.isClassOrInterfaceDeclaration())
				.forEach(member -> visit(member.asClassOrInterfaceDeclaration(), param));

			}

            @Override
            public void visit(MethodDeclaration node, List<MethodDeclaration> param)
            {
                System.out.println(node.getNameAsString());
                param.add(node.clone());
            }

         }, methodDeclarationList);

[PELock]

I cannot nest 2 visitors? Is that a problem too?

[jlerbsc]

The visitor you are using browses all the members of the class declaration...

You should look at the source of the VoidVisitorAdapter class and you'll immediately understand why.

[PELock]

Is there a way from the visitor perspective to make it visit only the direct children, not the nested items?

[jlerbsc]

You probably need to develop your own visitor. In this case, the class included is a member of the "mother" class. You can try what you suggested, i.e. excluding the method if the class doesn't match.

[jlerbsc]

Your code is invalid, still it treats the public void run() method as a member of outer class.

It was an example of what you can do.

[PELock]

Jup, checking for direct ownership

if (node.getParentNode().isPresent() && node.getParentNode().get() == nodeClass)

does the job. It would be cool if this sort of vistor be available by default.

Thank you for your help :)