Giter Site home page Giter Site logo

Comments (9)

willium avatar willium commented on May 22, 2024 2

+1 on not bundling a plotting library. Doesn't seem germane to the problems that this attempts to solve (dataframes).

from danfojs.

risenW avatar risenW commented on May 22, 2024

Hi @domoritz thanks for the feedback. We would definitely love to support other plotting libraries, but we had to bundle danfo with one for a start. We can definitely create wrappers that works with different backends going forward.

from danfojs.

domoritz avatar domoritz commented on May 22, 2024

Sounds great. Just wondering, why do you think danfo needs to be bundled with a plotting library. Wouldn't it be better to keep the dependencies lean and provide plotting as an extension? Instead of making .plot a function of a dataframe, you could even turn it around and plat(df). I can see that you want to stay close to Pandas but in js dependencies are a lot more expensive than in Python since you usually have to load the complete dependencies every time you run the code.

Either way, I'm super excited about danafo! We have previously built https://github.com/vega/datalib but did all the data munging in js.

from danfojs.

risenW avatar risenW commented on May 22, 2024

I totally get your point, what I think we can do is remove the plotting dependency and have users require it instead. Or we can create a more generic plotting module that can work with numerous plotting packages as you have earlier mentioned.
We can definitely redesign this if you're interested in working with us on it.

from danfojs.

domoritz avatar domoritz commented on May 22, 2024

I think unbundling plotting is probably the best approach as there are many js plotting libraries and it's not clear which one makes the most sense in a particular use case.

from danfojs.

Alex-Monahan avatar Alex-Monahan commented on May 22, 2024

Plotly is actually perfect for me, and I love having a .plot method on your DataFrame object! Please don't remove that capability, or please show me a path to re-import it! :-)

from danfojs.

domoritz avatar domoritz commented on May 22, 2024

The plotting library could extend danafo or you could call plot(dataFrame, ...) where you call dataFrame.plot(...) today.

from danfojs.

steveoni avatar steveoni commented on May 22, 2024

The plotting library could extend danafo or you could call plot(dataFrame, ...) where you call dataFrame.plot(...) today.

I totally agree with that. We can try creating a wrapper for some of the popular plotting libaries

from danfojs.

risenW avatar risenW commented on May 22, 2024

Plotly is actually perfect for me, and I love having a .plot method on your DataFrame object! Please don't remove that capability, or please show me a path to re-import it! :-)

Sure we won't remove support for it, we will just not bundle it together to reduce size, and then create a wrapped for it. This ensures we can create separate wrappers for different plotting package.

So we can do something similar to Plot(dataframe, Plotly) or Plot(dataframe, Vega)

from danfojs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.