Dataframes Merge Issue

[javascriptdata]

Dataframes Merge Issue

[steveoni]

I was not able to reproduce your error on Dnotebook.

What version of the library are you using?

[Pl-Mrcy]

I was able to reproduce it using Dnotebook.

const arrayShort = [
    {
        label: "ABC",
        value: 1
    },
    {
        label: "DEF",
        value: 2
    },
    {
        label: "GHI",
        value: 3
    }
];
const dfShort = new dfd.DataFrame(arrayShort);
const arrayLong = [
    {
        label: "ABC",
        value2: 4
    },
    {
        label: "DEF",
        value2: 5
    },
    {
        label: "JKL",
        value2: 6
    },
    {
        label: "MNO",
        value2: 7
    }
];
const dfLong = new dfd.DataFrame(arrayLong);

// 1
let howStr = "left"
let tmp = dfd.merge({
  left: dfLong,
  right:dfShort,
  on: ["label"],
  how: howStr
})
table(tmp.head());

// 2
howStr = "right"
tmp = dfd.merge({
  left: dfShort,
  right:dfLong,
  on: ["label"],
  how: howStr
})
table(tmp.head());

These two attempts give an error (TypeError: i is undefined) and a wrong output respectively.

I use [email protected]

[steveoni]

Thanks, I was able to reproduce the error. Its now fixed

[kickbox]

May I know when would this fix be released in node npm?