Giter Site home page Giter Site logo

Comments (3)

JayBizzle avatar JayBizzle commented on July 26, 2024

Would you like to submit a PR with the proposed changes?

Thanks

from crawler-detect.

kamdhenu avatar kamdhenu commented on July 26, 2024

Sorry but I'm still a novice PHP developer and yet to learn how to work with Git :-(

But, what I'm proposing here is changing the method getMatches(); inside "Jaybizzle\CrawlerDetect\CrawlerDetect" as below:

public function getMatches()
{
    return isset($this->matches[0]) ? trim(preg_replace('/[^A-Za-z0-9\-\_\.]/', ' ', $this->matches[0])) : null;
}

It will filter out any unwanted special characters and white spaces.

Here I assume that any detected bot should really not require any type of special characters, except a - (minus sign) and an _ (underscore) .

from crawler-detect.

JayBizzle avatar JayBizzle commented on July 26, 2024

Sorry for the delayed response.

I see where you are coming from, but the getMatches() method is not really used to return the exact bot that was detected, but more to return the exact portion of the user agent that caused the true response.

It would be nice to by able to have magic methods, such as isHubPages() but this would require us keeping a more complex database of bots and the beauty of this library is it's simplicity.

Always open to PRs though.

Thanks

from crawler-detect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.