Category and CategoryBase should be in separate apps

[jazzband]

Category and CategoryBase should be in separate apps

[jsoa]

Being a inner app of categories, its should be assumed that categories.editor cannot work properly without categories also installed.

[jsoa]

So after talking with @coordt, I realize that my previous comment is incorrect. If you subclass CategoryBase there is no need to add categories to INSTALLED_APPS. Sorry for misunderstanding the issue.

[winniehell]

Just to be sure: did you confirm the issue? :-)

[jsoa]

Yea, confirmed

[winniehell]

I would suggest to move the predefined category models into a sub-app called something like categories.basic and let the categories.editor functionality be part of the categories app, since it does not provide any standalone models. If you wish, I would make those changes and post another pull request.

[coordt]

@winniehell The only concern I have is for backwards compatibility. I would like people to be able to just add 'categories' and 'categories.editor' and have their categories. Can we reverse your suggestion and put CategoryBase in a sub app?

[winniehell]

Sure! As long as the stuff is separated in doesn't matter which way. It just made more sense to me having the categories app, which offers all the basic functionality and then the sub-app which does some additional stuff.

[ikresoft]

And one problem, if I have my own category model then 'categories' should be removed from settings.INSTALLED_APPS, when I remove it I don't have any more category_tags? I think it should be separated.

[coordt]

Good point. I would make your own template tag file and simply import everything from categories.templatetags.category_tags.

Would that work?

On Jul 26, 2013, at 9:23 AM, Enver [email protected] wrote:

And one problem, if I have my own category model then 'categories' should be removed from settings.INSTALLED_APPS, when I remove it I don't have any more category_tags?

—
Reply to this email directly or view it on GitHub.

[ikresoft]

Nice tip :)