SITE_ID dependancy.

[jazzband]

SITE_ID dependancy.

[mpasternak]

Hi @bahoo , from what I understand, you happen to have a non-SITE_ID dependent branch of dbtemplates? Would you mind submitting a PR against the current codebase?

[bahoo]

This is an old issue but I'm running into something similar, and found @iraabbott's two threads on the Django developer's group, which hopefully Ira doesn't mind my linking here directly!

I think it's a fix worth having the option for. I would also broadly suggest, Django's codebase is updated much more frequently than dbtemplates's is ( as of this writing, the last release was nearly two years ago ). So it probably makes sense to fork dbtemplates, and maybe pipenv install from a version control system as laid out here ( or hey, propose a PR to the project directly; I'd 👍 it ). Patching the smaller package probably helps with the principle of least astonishment, but I could be wrong on that. 💁‍♂️

I'm probably going to make a run of addressing this, but spitballing a bit myself / capturing my thoughts in case I don't get to it soon — I think even just patching this line in dbtemplates/loader.py to fall back more intelligently is probably the path of least resistance, maybe in cooperation with some of this middleware to store the current request. e.g.:

from django.core.exceptions import ImproperlyConfigured
from django_middleware_global_request.middleware import get_request

# ...

   try:
      site = Site.objects.get_current()
   except ImproperlyConfigured:
      request = get_request()
      site = Site.objects.get_current(request=request)

   print("and Bob's your uncle.")
     

Thank you for looking so far into this! Will follow up here as I get some working software ready. :D

[bahoo]

Will give this a few days for more changes before I press the issue, but for anyone curious: https://github.com/bahoo/django-dbtemplates

[guettli]

This could be solved via https://pypi.org/project/django-middleware-global-request/

With a global request, the code could always use Site.objects.get_current(request)