Regression: Paths to STATIC_ROOT must now end in os.sep

[jazzband]

Regression: Paths to STATIC_ROOT must now end in os.sep

[cyberdelia]

I can't reproduce your error, see and try branch fix-relpath. Can you explain me what exactly what broke ? It's maybe in another part of pipeline, I suspect absolute_path.

[cnorthwood]

I've tried that branch, however the error still occurs. The problem appears to be that the URLs to the compressed CSS are generated wrong - when I add the / to the end of my STATIC_ROOT, they appear correctly as /static/favourites/css/smart.css, but without, the path is just:

[cnorthwood]

Yes, the probably does appear to be in absolute_path. If on line 198 here: https://github.com/cyberdelia/django-pipeline/blob/master/pipeline/compressors/__init__.py#L198 I change it to:

path = os.path.join(start, path)

(i.e., get rid of the os.path.dirname), then it works. I don't know if that has any side effects

[cyberdelia]

Can you help me with more detail on how to reproduce (settings, original url, incorrect and correct result url) ? I want to add a regression test for this bug. You can also try to write the test by yourself, if it's easier for you ;)

[cnorthwood]

If you change line 21 here: https://github.com/cyberdelia/django-pipeline/blob/master/tests/runtests.py#L21 to get rid of the / on the end of the STATIC_ROOT setting (which is similar to how my STATIC_ROOT is defined, without the /), then your tests will fail

[cgreene]

I have been digging into this a bit. I can confirm that @cnorthwood's suggestion, "(i.e., get rid of the os.path.dirname), then it works," does in fact have side effects. Anything with a relative URL (i.e. image resources defined in the css) get the wrong path (the path includes the css path in the image location).

I think the correct fix is to take @cnorthwood's suggestion and then to also change
public_path = self.absolute_path(asset_path, css_path)
to
public_path = self.absolute_path(asset_path, os.path.dirname(css_path))
in construct_asset_path.

I can set up a pull request for this, I guess. This is the fix that we're now using locally.

[cyberdelia]

@cgreene We had the same finding at the same time, it's in the fix-relpath branch, that will be merged soon in master and released.
@cnorthwood Thanks for the report and the help to make it reproducible.