Comments (7)
Making this change is dangerous, because, previously, the permanent cache is done by setting timeout to 0 and a new version just do the opposite behavior. All behavior that are now supported on django 1.6, are already supported much earlier in django-redis.
I don't know the good way to change this mantaining backward compatibility.
from django-redis.
I think it's quite simple. Check the django version and use a settings.py entry. For 1.6 and up switch to the behaviour as documented in django 1.6. This means timeout = 0 will not cache indefinitely for django 1.6 users. If by any chance 1.6 users will want to keep the old behaviour, they can change the settings.py entry.
It's dangerous not to make any change, because 1.6 users who want to switch from django's default caching backends to yours can run into trouble.
I'll work this out in my fork anyways. Cheers!
from django-redis.
Great! Thanks!
from django-redis.
Allright, made an initial attempt to fix this. Changes can be found in client/default.py at lines 32 and 140 - 145. Changes should be self-explanatory.
from django-redis.
Sorry, but I don't have much time this week for it. This weekend this should be merged and fixed!
from django-redis.
Now partially merged with minor changes: 09939dc
Backward compatibility changes are not necessary, because 0 immediate timeout is only for memcached backend and django-redis can continue with own behavior :D
Thanks for your efforts!
from django-redis.
Thank you too! Even better :) who needs immediate timeouts anyway.
from django-redis.
Related Issues (20)
- Connection Pooling doesn't work as intended HOT 1
- Pytest 7.0 compatibility HOT 1
- Drop django 4.0
- Drop support for django 3.2 HOT 1
- How to configure and connect redis cluster correctly? HOT 2
- Django `TIMEOUT` setting not working as expected HOT 2
- Which timezone wil it take? system timezone or django timezone HOT 1
- Why Django Redis does not raise exception while connecting to Redis Server with SSL param equal string "False"
- `Expire` method fails when using `DEFAULT_TIMEOUT` HOT 1
- Getting/Setting occasionally extremely slow HOT 5
- django requirements update
- Add NX, XX, GT and LT to expire and pexpire HOT 2
- Multiple redis caches with fallback mechanism HOT 1
- Is it necessary to get coverage of tests directory? HOT 2
- Implementing HGET
- using redis in django getting connection error HOT 1
- strict_map_key
- Connection refused on Celery health checks HOT 3
- how to support hash ops, such as hset, hget...
- Reauthentication with Azure AD / Entra ID
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-redis.