keys() call with custom KEY_FUNCTION

[jazzband]

keys() call with custom KEY_FUNCTION

[teferi]

Does this mean that you use a custom make_key() function?
Django doesn't provide a way to convert key returned by make_key() back to original, but it might be a good idea to provide such a function smth like reverse_key() (or make_reverse_key() or reverse_make_key()) and allow it to be overridden for this purpose.

[askaliuk]

Yes. https://docs.djangoproject.com/en/dev/ref/settings/#std:setting-CACHES-KEY_FUNCTION

Correct. Django doesn't provide way to convert back. But django-redis blindly assumes that i use standard function and converts it back in the code line, which i mentioned.
I think make_reverse_key() should be defined somewhere in code (e.g. with standard implementation or NotImplementedError) and django-redis should provide way to override it.

[niwinz]

Yes, django-redis asumes that default function is used.

I really like suggestions, any one have time for implement this? this month I'm really busy... :(

[teferi]

I'll have some time to implement it this weekend (seems easy enough)

[teferi]

I still wish to write some tests with custom functions (It turned out to be a little more tricky than I thought, as I cache the function on module level). Also is documentation inside doc/ the one I should update? I feel that we should warn users if they use custom KEY_FUNCTION.

Btw: is it even possible to just attach a PR to an issue without creating a new issue?

[teferi]

Oh wait! I think I got it wrong. It should be a parameter to backend, not a separate setting.
Edit:
Fixed that, still have to add tests with custom function.

[teferi]

I've written a test for custom function and fixed tests on all the pythons and djangos you test. =) @niwibe could you please review the #81 PR? I can squash commits if you wish, and I guess we should add info about the function to docs if code is ok.

[niwinz]

Merged and released ;) Thanks!