Comments (11)
Thank you, lovely to hear! Let me know if I can help in any way.
from django-simple-history.
Ah, sorry, I misread your description π I'm able to reproduce it, and will open a PR for it :)
from django-simple-history.
@alimony if this is an urgent thing for you, please write the test case and attempt a fix. Anything that gets things started will help tremendously.
from django-simple-history.
Thanks a lot @ddabble !
from django-simple-history.
I'm not sure I'm able to reproduce your issue π€ Calling e.g. add()
with multiple arguments should only create one historical record (see e.g. this test case)... Could you provide some (complete) test case code that reproduces your issue? π
from django-simple-history.
This is not about duplicate records, but duplicate database queries, as identified by e.g. Django Debug Toolbar. Itβs a performance issue. Can you also see duplicate queries by inspecting with debug toolbar? If not, Iβll try and make a test case.
from django-simple-history.
Any update on this?
from django-simple-history.
I've made a fix for it locally, but considering that @tim-schilling and I are the only currently active maintainers, I want to focus on finishing #1128 first, which seems close to being merged π
from django-simple-history.
@ddabble Any idea when we might see this in a release?
from django-simple-history.
I'm planning on creating a new release after #1344 has been merged π
from django-simple-history.
@alimony I've created a GitHub release for version 3.6.0, but it's yet to be published to PyPI; see progress in #1345
from django-simple-history.
Related Issues (20)
- How to annotate the historical model to the QuerySet HOT 3
- not working abstract model HOT 1
- "update_fields" option to "bulk_create" not supported? HOT 1
- Add optimized update_or_create Manager method
- HistoricForeignKey is very slow HOT 2
- Release current main branch to PyPi HOT 1
- Remove the "not created" condition from post_save when skipping history creation HOT 1
- m2m historical records are saved even when SIMPLE_HISTORY_ENABLED = False
- skip_history_when_saving if model has no any changes HOT 3
- Sending create_historical_record() to celery tasks HOT 8
- Integration with admin.Models failing
- Not null constraint fails with inheritance and m2m fields
- Django polymorphic compatibility
- create_historical_record_m2ms does not respect model's excluded_field_kwargs
- Convenience Method and naming clarification for as_of
- Incorrect rendering of history entry (with editable fields) if changing is disallowed HOT 1
- bulk_update_with_history should use update_fields: history log incorrectly showing phantom changes
- Add support for skip_history_when_saving in M2M fields
- Link a model to a specific record
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-simple-history.