Giter Site home page Giter Site logo

Comments (11)

alimony avatar alimony commented on August 16, 2024 2

Thank you, lovely to hear! Let me know if I can help in any way.

from django-simple-history.

ddabble avatar ddabble commented on August 16, 2024 1

Ah, sorry, I misread your description πŸ˜… I'm able to reproduce it, and will open a PR for it :)

from django-simple-history.

tim-schilling avatar tim-schilling commented on August 16, 2024 1

@alimony if this is an urgent thing for you, please write the test case and attempt a fix. Anything that gets things started will help tremendously.

from django-simple-history.

alimony avatar alimony commented on August 16, 2024 1

Thanks a lot @ddabble !

from django-simple-history.

ddabble avatar ddabble commented on August 16, 2024

I'm not sure I'm able to reproduce your issue πŸ€” Calling e.g. add() with multiple arguments should only create one historical record (see e.g. this test case)... Could you provide some (complete) test case code that reproduces your issue? πŸ™‚

from django-simple-history.

alimony avatar alimony commented on August 16, 2024

This is not about duplicate records, but duplicate database queries, as identified by e.g. Django Debug Toolbar. It’s a performance issue. Can you also see duplicate queries by inspecting with debug toolbar? If not, I’ll try and make a test case.

from django-simple-history.

alimony avatar alimony commented on August 16, 2024

Any update on this?

from django-simple-history.

ddabble avatar ddabble commented on August 16, 2024

I've made a fix for it locally, but considering that @tim-schilling and I are the only currently active maintainers, I want to focus on finishing #1128 first, which seems close to being merged πŸ™‚

from django-simple-history.

alimony avatar alimony commented on August 16, 2024

@ddabble Any idea when we might see this in a release?

from django-simple-history.

ddabble avatar ddabble commented on August 16, 2024

I'm planning on creating a new release after #1344 has been merged πŸ™‚

from django-simple-history.

ddabble avatar ddabble commented on August 16, 2024

@alimony I've created a GitHub release for version 3.6.0, but it's yet to be published to PyPI; see progress in #1345

from django-simple-history.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.