Rendering the same field still rembembers attribute

[jazzband]

Rendering the same field still rembembers attribute

[shwoop]

Hi, I've come across a similar issue so thought I should add my findings here.
Using django-widget-tweaks 1.4.1 (master 970bf5b)
I added the below tests, to match my use case, which seems to mirror your own, and have found that the tests pass with django 1.4 to 1.7 but begin throwing errors in django 1.8.
I will report back if I find anything further.

New tests:

diff --git a/widget_tweaks/tests.py b/widget_tweaks/tests.py
index 454064a..6ff9f83 100644
--- a/widget_tweaks/tests.py
+++ b/widget_tweaks/tests.py
@@ -318,6 +318,32 @@ class RenderFieldTagFieldReuseTest(TestCase):
         self.assertEqual(res.count("class0"), 3)
         self.assertEqual(res.count("bar"), 1)
 
+    def test_field_double_rendering_id(self):
+        res = render_form('{{ form.simple }}{% render_field form.simple id="id_1" %}{% render_field form.simple id="id_2" %}')
+        self.assertEqual(res.count("id_1"), 1)
+        self.assertEqual(res.count("id_2"), 1)
+
+    def test_field_double_rendering_id_name(self):
+        res = render_form('{{ form.simple }}{% render_field form.simple id="id_1" name="n_1" %}{% render_field form.simple id="id_2" name="n_2"%}')
+        self.assertEqual(res.count("id_1"), 1)
+        self.assertEqual(res.count("id_2"), 1)
+        self.assertEqual(res.count("n_1"), 1)
+        self.assertEqual(res.count("n_2"), 1)
+
+    def test_field_double_rendering_id_class(self):
+        res = render_form('{{ form.simple }}{% render_field form.simple id="id_1" class="c_1" %}{% render_field form.simple id="id_2" class="c_2" %}')
+        self.assertEqual(res.count("id_1"), 1)
+        self.assertEqual(res.count("id_2"), 1)
+        self.assertEqual(res.count("c_1"), 1)
+        self.assertEqual(res.count("c_2"), 1)
+
+    def test_field_double_rendering_name_class(self):
+        res = render_form('{{ form.simple }}{% render_field form.simple name="n_1" class="c_1" %}{% render_field form.simple name="n_2" class="c_2" %}')
+        self.assertEqual(res.count("n_1"), 1)
+        self.assertEqual(res.count("n_2"), 1)
+        self.assertEqual(res.count("c_1"), 1)
+        self.assertEqual(res.count("c_2"), 1)
+
 
 class RenderFieldTagUseTemplateVariableTest(TestCase):
     def test_use_template_variable_in_parametrs(self):

Failing tests, with django 1.8+:

[~/repos/django-widget-tweaks]$ ./runtests.py                                                                                                                                                            *[master] 
......x...............x..FFF.................
======================================================================
FAIL: test_field_double_rendering_id_class (widget_tweaks.tests.RenderFieldTagFieldReuseTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/alistair/repos/django-widget-tweaks/widget_tweaks/tests.py", line 335, in test_field_double_rendering_id_class
    self.assertEqual(res.count("id_1"), 1)
AssertionError: 2 != 1

======================================================================
FAIL: test_field_double_rendering_id_name (widget_tweaks.tests.RenderFieldTagFieldReuseTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/alistair/repos/django-widget-tweaks/widget_tweaks/tests.py", line 328, in test_field_double_rendering_id_name
    self.assertEqual(res.count("id_1"), 1)
AssertionError: 2 != 1

======================================================================
FAIL: test_field_double_rendering_name_class (widget_tweaks.tests.RenderFieldTagFieldReuseTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/alistair/repos/django-widget-tweaks/widget_tweaks/tests.py", line 342, in test_field_double_rendering_name_class
    self.assertEqual(res.count("n_1"), 1)
AssertionError: 2 != 1

----------------------------------------------------------------------
Ran 45 tests in 0.050s

FAILED (failures=3, expected failures=2)

[shwoop]

This usage pattern works with v1.4, prior to 56e0072 was added to fix this issue.

[shwoop]

It seems I had a separate issue with v1.4 so have had to patch v1.4.1 and create a new pull request #42 that resolves this issue without regressing issue #21

[kmike]

@bircow could you please check django-widget-tweak master - have #42 fixed your issue?