Giter Site home page Giter Site logo

Comments (8)

jezdez avatar jezdez commented on June 30, 2024 2

Done!

from help.

hugovk avatar hugovk commented on June 30, 2024

Changes look good. 👍

To ease future maintainence burden, I suggest adding a no-op job that depends on the main job, and just echoes a success message.

Then the CI can just mark the no-op job as required. Then, when new versions are released and EOL versions are dropped, we aren't blocked on a roadie bottleneck to adjust the settings.

For example:

https://github.com/hugovk/norwegianblue/blob/71fcbb570406f27d11c9b91f22fec49cfbf2ef69/.github/workflows/test.yml#L49-L55

from help.

jezdez avatar jezdez commented on June 30, 2024

Sounds like a good idea, I've looked at the change. It's a good idea.

from help.

n2ygk avatar n2ygk commented on June 30, 2024

@jezdez @dopry where to we stand with this? Should you add @hugovk's suggestion?

from help.

jezdez avatar jezdez commented on June 30, 2024

@n2ygk Yep, I said as much in jazzband/django-oauth-toolkit#1219 (comment).

As a slight alteration of the plan, it might be useful to use https://github.com/test-summary/action to print out information about the test run.

from help.

n2ygk avatar n2ygk commented on June 30, 2024

@jezdez so I believe only you can implement this change, is that correct? If so, please do!

from help.

dopry avatar dopry commented on June 30, 2024

@jezdez I've added the success job. Can you update the required checks on the branch protection now?

from help.

dopry avatar dopry commented on June 30, 2024

awesome. thank you.

from help.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.