Sprintf always evaluated no matter the log level

[jcelliott]

Sprintf always evaluated no matter the log level

[gunnihinn]

Hum... wait a minute, I'm the idiot here, that expensive function was already called every time I called the Debug function to pass a string to it as an argument. I was apparently confused and thought your Debug function worked like an #ifdef in C, which it doesn't and doesn't claim to.

Nevermind me.

[jcelliott]

You are correct about functions being called before their results are passed into the logging functions. The way to work with expensive debuging function calls is by using the Is* functions. For example:

if lumber.IsDebug() {
    lumber.Debug("expensive data structure: %+v", getExpensiveDataStructure())
}

You were also correct about the printf arguments being evaluated when they shouldn't have been. I fixed that a while back for the filelogger, bug forgot to change it for the consolelogger, so I have just updated that.