Support jQuery 4.0

[jcubic]

Support jQuery 4.0

[jcubic]

version 2.39.0, with jQuery 4.0 support, just got released.

[badulesia]

Hi.
Can we assume that this will be included in the next release? I'm trying to convert my project to Jquery4. I have some minor incompatibilities with plugins such a Terminal.

[jcubic]

Yes, it will be included in the next version. jQuery 4.0 final has not yet been released that's why I haven't published a new version yet.

Temporarily you use grab the file from CDN:

https://cdn.jsdelivr.net/gh/jcubic/jquery.terminal@devel/js/jquery.terminal.min.js

[badulesia]

Yes I'm aware that Jquery 4 is only at beta stage, and it's fresh. I can assume now this is solved, or soon to be.
Thank you.

[jcubic]

I don't have any features or bug fixes to release right now, so I think that I will just release the fix for jQuery 4.0. I'm not sure if should be a bug-fix release or a feature.

[badulesia]

Consider the importance of jQuery, make it a feature.
Beyond this, the two functions involved are deprecated since jQuery 3.3. Wouldn't it be better to review the code and remove them? Replace with pure JS.

[jcubic]

@badulesia all deprecated functions got removed. Just look at the diff.

[badulesia]

I'm not sure in which branch I should check. The Jquery 4 one hasn't been update recently. I do trust you.

[jcubic]

Sorry, it's on the devel branch like on the CDN link I've shared.

[badulesia]

Perfect, thank you.