Giter Site home page Giter Site logo

Comments (9)

jcubic avatar jcubic commented on May 17, 2024 1

@ballonura by style object if you mean style tag: <style></style> then I would prefer to not include additional DOM elements, we have only a single iframe tag. But maybe if users will use more than one iframe that will make sense.

from sysend.js.

jcubic avatar jcubic commented on May 17, 2024

Are you sure you mean to take place in DOM? display: none doesn't remove the element from DOM. But I need to check if display: none makes Cross Domain work on every platform. I don't remember why it's like this, but this was probably added for a reason.

from sysend.js.

ballonura avatar ballonura commented on May 17, 2024

Are you sure you mean to take place in DOM? display: none doesn't remove the element from DOM. But I need to check if display: none makes Cross Domain work on every platform. I don't remember why it's like this, but this was probably added for a reason.

Maybe we should consider add a style obj, that can dynamically apply to the brand new iframe element?

from sysend.js.

RoniGordin avatar RoniGordin commented on May 17, 2024

Are you sure you mean to take place in DOM? display: none doesn't remove the element from DOM. But I need to check if display: none makes Cross Domain work on every platform. I don't remember why it's like this, but this was probably added for a reason.

Sorry, I meant it takes space, the element containing it overflows

from sysend.js.

jcubic avatar jcubic commented on May 17, 2024

Will check maybe the iframe has padding, or maybe because it's an inline element.

from sysend.js.

jcubic avatar jcubic commented on May 17, 2024

@RoniGordin For me, it has a size 0x0px so it doesn't take up any space. Maybe you have other CSS that is applied globally.

but I can add

position: absolute;
left: 0;
top: 0;

or even -99999px; so it's outside the page.

from sysend.js.

jcubic avatar jcubic commented on May 17, 2024

Should be fixed now

from sysend.js.

ballonura avatar ballonura commented on May 17, 2024

@ballonura by style object if you mean style tag: <style></style> then I would prefer to not include additional DOM elements, we have only a single iframe tag. But maybe if users will use more than one iframe that will make sense.

Thx for the quick response.

from sysend.js.

RoniGordin avatar RoniGordin commented on May 17, 2024

Should be fixed now

Tested now, looks perfect
Thank you so much! 🙏

from sysend.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.