Comments (9)
@ballonura by style object if you mean style tag: <style></style>
then I would prefer to not include additional DOM elements, we have only a single iframe tag. But maybe if users will use more than one iframe that will make sense.
from sysend.js.
Are you sure you mean to take place in DOM? display: none
doesn't remove the element from DOM. But I need to check if display: none
makes Cross Domain work on every platform. I don't remember why it's like this, but this was probably added for a reason.
from sysend.js.
Are you sure you mean to take place in DOM?
display: none
doesn't remove the element from DOM. But I need to check ifdisplay: none
makes Cross Domain work on every platform. I don't remember why it's like this, but this was probably added for a reason.
Maybe we should consider add a style obj
, that can dynamically apply to the brand new iframe
element?
from sysend.js.
Are you sure you mean to take place in DOM?
display: none
doesn't remove the element from DOM. But I need to check ifdisplay: none
makes Cross Domain work on every platform. I don't remember why it's like this, but this was probably added for a reason.
Sorry, I meant it takes space, the element containing it overflows
from sysend.js.
Will check maybe the iframe has padding, or maybe because it's an inline element.
from sysend.js.
@RoniGordin For me, it has a size 0x0px so it doesn't take up any space. Maybe you have other CSS that is applied globally.
but I can add
position: absolute;
left: 0;
top: 0;
or even -99999px;
so it's outside the page.
from sysend.js.
Should be fixed now
from sysend.js.
@ballonura by style object if you mean style tag:
<style></style>
then I would prefer to not include additional DOM elements, we have only a single iframe tag. But maybe if users will use more than one iframe that will make sense.
Thx for the quick response.
from sysend.js.
Should be fixed now
Tested now, looks perfect
Thank you so much! 🙏
from sysend.js.
Related Issues (20)
- isPrimary() returns true on new tab HOT 4
- Add chaining
- Support cross-domain in both directions with single proxy page HOT 2
- Tracking is broken
- Broken link on demo page HOT 1
- Add links to articles about sysend
- Use localstorage option in sysend HOT 7
- Does sysend.js implement the BroadcastChannel API? HOT 5
- The event is invalid after upgrading the version. HOT 10
- proxy parameter in typescript not allows domains population HOT 2
- Unexpected arrow function HOT 2
- Possible security issue using postMessage with "*" as target HOT 5
- Add demo for single window/tab requests and response query HOT 2
- Add more examples to README
- The cross-domains communication doesn't work anymore HOT 1
- Can we Inject javascript in new tab ? HOT 4
- Cross-domain communication broken in latest Chrome (115+) HOT 41
- Create new multi window demo
- The iframe created by the proxy method will be created repeatedly. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sysend.js.