Comments (4)
@steviegt6 yes that works, thanks for the info!
from microcraft.
I don't think he ever implemented it in the game as a mechanic.
from microcraft.
It seems as though this is supposed to happen, as this code seems to try to do that, the issue is it's in the hit()
method instead of the onHit()
method, so it never gets called as the chest can't hit something (At least I don't think it can).
// EntityChest.java
@Override
public boolean hit(Entity e) {
if (super.hit(e)) {
for (ItemStack s : this.inventory.stacks) {
EntityItem.spawn(this.level, s, Level.toCenter(e.tileX), Level.toCenter(e.tileY));
}
return true;
}
return false;
}
A potential fix could be Overriding the getDrops()
method (which gets called when the furniture item is hit) to also return all of the items inside the chest instead of just the chest item itself.
// EntityFurniture.java
protected List<ItemStack> getDrops() {
return List.of(new ItemStack(new ItemInstance(this.item)));
}
// EntityChest.java
@Override
protected List<ItemStack> getDrops() {
List<ItemStack> temp = this.inventory.stacks;
temp.addAll(super.getDrops());
return temp;
}
from microcraft.
It seems as though this is supposed to happen, as this code seems to try to do that, the issue is it's in the
hit()
method instead of theonHit()
method, so it never gets called as the chest can't hit something (At least I don't think it can).// EntityChest.java @Override public boolean hit(Entity e) { if (super.hit(e)) { for (ItemStack s : this.inventory.stacks) { EntityItem.spawn(this.level, s, Level.toCenter(e.tileX), Level.toCenter(e.tileY)); } return true; } return false; }
A potential fix could be Overriding the
getDrops()
method (which gets called when the furniture item is hit) to also return all of the items inside the chest instead of just the chest item itself.// EntityFurniture.java protected List<ItemStack> getDrops() { return List.of(new ItemStack(new ItemInstance(this.item))); }
// EntityChest.java @Override protected List<ItemStack> getDrops() { List<ItemStack> temp = this.inventory.stacks; temp.addAll(super.getDrops()); return temp; }
Can confirm that this is a valid solution.
from microcraft.
Related Issues (14)
- Compatibility problems on Linux HOT 1
- climbed stairs twice and got index out of bounds
- [Java 15] Can't run game with source code HOT 2
- wont run HOT 3
- How do you plant seeds? HOT 5
- Breaking a filled chest voids all items
- add save and load pls also i can't get out of my spawn
- the cloud world stairs spawned right next to the spawn location
- Being on top of an acorn when it grows, makes the player stuck.
- won't open?? HOT 2
- [NOT A BUG] HOT 2
- Couldn't build project on Macbook HOT 3
- Running Microcraft in a container
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from microcraft.