Comments (4)
jeaiii
commented on May 23, 2024
1
clean to warning level 4
ebde9d3
from itoa.
jeaiii
commented on May 23, 2024
does n /= U(1e8); fix it too?
from itoa.
Tisten
commented on May 23, 2024
Well, 1e8 doesn't fit in uint8_t so you will get non-working code and these instead:
warning C4310: cast truncates constant value
warning C4723: potential divide by 0
from itoa.
jeaiii
commented on May 23, 2024
ah, because the MSVC compiler didn't realize that n can't be a uint8_t at that point in the code...okay
from itoa.
Related Issues (12)
- How hard would it be to provide a C version of jeaiii_to_text.h? HOT 2
- Issue in integer to string conversion HOT 3
- Features: zero-padding and fixed-point HOT 2
- Versions for uint8_t, int8_t, uint16_t and int16_t HOT 1
- C conversion/adaptation of jeaiii_to_text.h compared to C conversion/adaptation of itoa_jeaiii.cpp not as much faster as hoped HOT 1
- Clarify roles of the two implementations HOT 2
- Clang missing-braces
- FYI, we're using this in MoarVM HOT 1
- GCC warning due to ASCII art HOT 7
- I don't think `n` can ever be < 10 here
- remove usage of template variable `mask` to support c++11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from itoa.