Comments (3)
jech
commented on September 28, 2024
The out-of-bound reads look like false positives. real_prefix is set to prefix + 12 only in the IPv4 case, in which case only 4 bytes of real_prefix are accessed. The 16-byte case is in the IPv6 case, in which case real_prefix is equal to prefix.
The out-of-boud write I don't understand. In any case, it doesn't seem to trigger valgrind.
277081 is a real bug — the semantics of the right-shift operator in C is crazy, it's undefined if the right operand is large. An explicit conditional is needed.
from babeld.
MisterDA
commented on September 28, 2024
See e773eda for a possible right-shifting UB fix. When the shift is too big, I simply reset to zero the reach history.
Would you prefer to see sizeof(hist->reach) * CHAR_BIT rather than sizeof(hist->reach) * 8?
from babeld.
jech
commented on September 28, 2024
I believe this is fixed now. Please reopen or create a new issue if that's not the case.
from babeld.
Related Issues (20)
- kernel_route: Invalid argument HOT 2
- bugs in parse_hello_subtlv, parse_ihu_subtlv, parse_request_subtlv, parse_seqno_request_subtlv, and parse_other_subtlv HOT 2
- Babeld does not function properly HOT 1
- Feature request: exchange arbitrary strings HOT 4
- incorrect checkings in babel HOT 1
- obscure error message: babeld: send: Destination address required HOT 10
- babeld replaces routes non-atomically HOT 1
- routing loop due to ignoring linkdown HOT 3
- Need help with redistribute default routes HOT 4
- Interface Regex? HOT 1
- Inject routes with different mtu? HOT 3
- Is there intention to support IPv4 multicast group as well? HOT 1
- Error : Generating IPV6 Address HOT 1
- Same route announced twice? HOT 2
- Upper Bound on Interface Count? HOT 4
- Denying routes in install filter doesn't work HOT 6
- Release tag missing for 1.11 HOT 1
- 1.12 tag missing HOT 1
- Check Interfaces in add_interface HOT 2
- babeld 1.12.1 build failure HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babeld.