Comments (3)
I can't remember the specific reason that I set it up that way originally. I think it had to do with the timing of when plugins were initialized.
The merging of plugin options with global options is the main reason to have the plugin and it's options separate, but I believe there are only a few plugins that really take advantage of this. autoprefixer
is an example since the browserlist config can be passed in when using this package as part of ember-cli-postcss
.
I think your proposal is sound and would work well. If users of this plugin want to specify plugins with the array format and pass the options directly to the plugin function, then they'll need to manage the options themselves anyway.
If you have time to put together a PR I'd really appreciate it and I'm open to supporting both methods.
from broccoli-postcss.
Sweet! I'll do that then. I have the test written for the method I suggested, but wanted to make sure you're cool with both methods before writing the code and asking you to support two methods.
from broccoli-postcss.
Thanks for checking, sounds good!
from broccoli-postcss.
Related Issues (20)
- Callbacks as plugins HOT 3
- The engine "node" is incompatible with this module
- Recompile while imported style file has changed? HOT 6
- Processing issue HOT 5
- Support for node 11 HOT 1
- Support for nodejs 12.x? HOT 5
- Support postcss.config.js standard format HOT 3
- Doesn't work with autoprefixer 10 HOT 1
- TypeError: Class constructors cannot be invoked without 'new' HOT 1
- An in-range update of async is breaking the build 🚨 HOT 1
- An in-range update of nyc is breaking the build 🚨
- An in-range update of coveralls is breaking the build 🚨
- An in-range update of mocha is breaking the build 🚨
- An in-range update of coveralls is breaking the build 🚨
- An in-range update of nyc is breaking the build 🚨
- An in-range update of async is breaking the build 🚨
- An in-range update of nyc is breaking the build 🚨
- An in-range update of mocha is breaking the build 🚨 HOT 1
- An in-range update of eslint-plugin-import is breaking the build 🚨
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broccoli-postcss.