Giter Site home page Giter Site logo

Comments (3)

jeffjewiss avatar jeffjewiss commented on May 25, 2024

I can't remember the specific reason that I set it up that way originally. I think it had to do with the timing of when plugins were initialized.

The merging of plugin options with global options is the main reason to have the plugin and it's options separate, but I believe there are only a few plugins that really take advantage of this. autoprefixer is an example since the browserlist config can be passed in when using this package as part of ember-cli-postcss.

I think your proposal is sound and would work well. If users of this plugin want to specify plugins with the array format and pass the options directly to the plugin function, then they'll need to manage the options themselves anyway.

If you have time to put together a PR I'd really appreciate it and I'm open to supporting both methods.

from broccoli-postcss.

alexlafroscia avatar alexlafroscia commented on May 25, 2024

Sweet! I'll do that then. I have the test written for the method I suggested, but wanted to make sure you're cool with both methods before writing the code and asking you to support two methods.

from broccoli-postcss.

jeffjewiss avatar jeffjewiss commented on May 25, 2024

Thanks for checking, sounds good!

from broccoli-postcss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.