Comments (10)
It seems V4L2VideoDecoder::Create
is defined in /media/gpu/v4l2/v4l2_video_decoder.cc
which is guarded by if (!use_linux_v4l2_only)
.
So it seems they did some refactoring.
I can try to remove the "use_linux_v4l2_only" flag so these files get built as well.
from meta-rockchip.
@JeffyCN
It seems the following is required (on top of the existing patches) to make Chromium 98 build again:
Fix for undefined symbol: media::V4L2VideoDecoder::Create
in /media/gpu/chromeos/video_decoder_pipeline.cc:
--- a/media/gpu/v4l2/BUILD.gn 2022-03-11 10:31:31.649092450 +0100
+++ b/media/gpu/v4l2/BUILD.gn 2022-03-11 13:38:00.834024785 +0100
@@ -51,6 +51,8 @@
"v4l2_video_decoder_backend_stateful.h",
"v4l2_video_encode_accelerator.cc",
"v4l2_video_encode_accelerator.h",
+ "v4l2_video_decoder.cc",
+ "v4l2_video_decoder.h",
]
if (!use_linux_v4l2_only) {
@@ -60,8 +62,6 @@
"v4l2_decode_surface_handler.h",
"v4l2_slice_video_decode_accelerator.cc",
"v4l2_slice_video_decode_accelerator.h",
- "v4l2_video_decoder.cc",
- "v4l2_video_decoder.h",
"v4l2_video_decoder_backend_stateless.cc",
"v4l2_video_decoder_backend_stateless.h",
"v4l2_video_decoder_delegate_h264.cc",
Fix for undefined symbol: base::SequencedTaskRunnerHandle::Get
in media/gpu/v4l2/v4l2_video_decoder.cc:
--- a/media/gpu/v4l2/v4l2_video_decoder.cc 2022-03-11 10:31:31.433091249 +0100
+++ b/media/gpu/v4l2/v4l2_video_decoder.cc 2022-03-11 13:45:04.486423379 +0100
@@ -11,6 +11,7 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/task/post_task.h"
+#include "base/threading/sequenced_task_runner_handle.h"
#include "base/trace_event/trace_event.h"
#include "media/base/limits.h"
#include "media/base/media_log.h"
Correct me if I'm wrong but this makes it build again with:
use_v4l2_codec=true
use_v4lplugin=true
use_linux_v4l2_only=true
from meta-rockchip.
the video encoder/decoder were only enabled in chromeos before, so it's hard to enable vda/vea without bring in some chromeos stuff. i will check it the next week
from meta-rockchip.
yes, you are right.
patches uploaded(2345140), which is much the same as what you did
from meta-rockchip.
Thanks :) !
from meta-rockchip.
Hi @JeffyCN
If you happen to have some spare time, could you please rebase on chromium 100 ?
They just pushed it to meta-browser.
Thanks in advance!
from meta-rockchip.
i've been busy these days, should be able to port it before the end of the next week...
from meta-rockchip.
@MastaG , i've ported the patches:wip/chromium_100
but haven't got time to test it
from meta-rockchip.
@JeffyCN thanks a lot bro!
I'll build it tomorrow and hope to run it later this week 👍
from meta-rockchip.
patches uploaded
from meta-rockchip.
Related Issues (20)
- rknn-toolkit is not working for model transfering HOT 3
- ADBD is not fully working . HOT 6
- How to login into system? HOT 4
- Modifying boot logos on RK3288 HOT 1
- OTA Update / Additional partition HOT 14
- RAUC Integration HOT 7
- Running bitbake -c clean deletes rkbin HOT 1
- rk3588 weston cannot start HOT 5
- What is the best way to enable uart? HOT 2
- Build gnome desktop base on x11 HOT 1
- WPEwebkit on rk3288 HOT 11
- Update patches for newer version of chromium HOT 4
- Starting kernel invokes ""Synchronous Abort" - rk3328 HOT 14
- support for RV11XX SoCs HOT 1
- RK3399 & RK3568 reset/reboot every 10min HOT 5
- use local source code and change uart debug HOT 3
- RK3588
- Rock3 Model C, build settings HOT 7
- linux-libc-headers-4.19-custom-r0 do_install: oe_runmake failed
- bitbake core-image-minimal returns errors with Machine = "rockchip-rk3326-evb" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meta-rockchip.