Issues with echo: false and not on TTY

[cabello]

Issues with echo: false and not on TTY

[cabello]

I just confirmed this works as expected. Thanks for the quick fix.

[abinoam]

Great catch. Confirmed in my machine. I can't promise taking a look at it really quickly. But I'll try it at least next week. (If you see a patch before this, please open a PR). This may have a huge impact in running scripts in pipes.

Thank you.

[abinoam]

Perhaps related to piotrmurach/tty-prompt#49

[abinoam]

Checking here that input.tty? and input.isatty is false when pipeing and true calling the script directly.
But perhaps this check is not reliable between platforms.
No methods from HighLine::Terminal::IOConsole works correctly (when pipeing. eg: terminal_size)
This points to us that we should identify early and use another terminal class to handle it (to be created).

Ruby stdlib io/console has advanced a little from my last touch at this code. Now we have things like getpass (http://ruby-doc.org/stdlib-2.6/libdoc/io/console/rdoc/IO/generic_readable.html#method-i-getpass). Some things in HighLine should be directly relying on it.

[abinoam]

Well, currently we treat input, output as being from the same "type". But when pipeing input can be a file and output a terminal.

[abinoam]

I've just assembled a quick and dirt fix.
Released https://rubygems.org/gems/highline/versions/2.0.1
@cabello could you please give me any feedback if this fix is enough for your software.
I'll probably look at this later for a better solution.

[abinoam]

The HighLine's assumption that input and output is the same type is broken.