Question: Resource (User/Group) ID substitution in scim gateway

[jelhub]

Question: Resource (User/Group) ID substitution in scim gateway

[jelhub]

It's now fixed in v4.1.3

[jelhub]

PR not needed.
Will be included in next update

Thanks,
Jarle

[jelhub]

Hi,
getUser() should support returning id, and we have to use this method for adding the id to the full user object. If id not supported, it will be set to userName/externalID.

A1)
Returned id will be use and not substituted.
Ref: https://github.com/jelhub/scimgateway/blob/master/lib/scimgateway.js#L1112
Seems your getUser() does not return the id

A2)
Not sure I understand this question?

Regards,
Jarle

[jelhub]

I see that code could have been improved by skipping getUser() if the the plugin createUser() do return an object that includes the id.

ref: https://github.com/jelhub/scimgateway/blob/master/lib/scimgateway.js#L1087-L1090

That's probably what you meant with Q2?

Jarle

[j--wong]

Thanks for the reply. Yes, if we skip the getUser() call if the object (returned by the plugin) already contains the id would fix the issue we are encountering.

Would you like me to PR that in? I would just put in a check like this:

if (!jsonBody.id) {
  let obj
  try { // retrieve id
    if (handle.createMethod === 'createUser') {
      if (jsonBody.userName) {
        jsonBody.id = jsonBody.userName
        obj = await this[handle.getMethod](ctx.params.baseEntity, { attribute: 'userName', operator: 'eq', value: jsonBody.userName }, ['id', 'userName'])
      } else if (jsonBody.externalId) {
        jsonBody.id = jsonBody.externalId
        obj = await this[handle.getMethod](ctx.params.baseEntity, { attribute: 'externalId', operator: 'eq', value: jsonBody.externalId }, ['id', 'externalId'])
      }
    } else if (handle.createMethod === 'createGroup') {
      if (jsonBody.externalId) {
        jsonBody.id = jsonBody.externalId
        obj = await this[handle.getMethod](ctx.params.baseEntity, { attribute: 'externalId', operator: 'eq', value: jsonBody.externalId }, ['id', 'externalId'])
      } else if (jsonBody.displayName) {
        jsonBody.id = jsonBody.displayName
        obj = await this[handle.getMethod](ctx.params.baseEntity, { attribute: 'displayName', operator: 'eq', value: jsonBody.displayName }, ['id', 'displayName'])
      }
    }
  } catch (err) { }
  if (obj && obj.id) jsonBody.id = obj.id
}

[j--wong]

Amazing, thank you @jelhub