Giter Site home page Giter Site logo

Comments (7)

jenil avatar jenil commented on May 23, 2024 1

cool, will review it over the weekend

from bulmaswatch.

jenil avatar jenil commented on May 23, 2024

I'm not sure what the issue is. Both the fonts load and both can be applied using respective CSS right?
Are you saying you just want to optimize the loading by just 1 web request for fonts?

from bulmaswatch.

raniesantos avatar raniesantos commented on May 23, 2024

Are you saying you just want to optimize the loading by just 1 web request for fonts?

Yes, that's exactly what I'm trying to do. I know following PageSpeed isn't absolutely necessary but I just want to clear some of the warnings. The way the themes are setup prevent me from being able to.

Solution no. 2 seems easy enough to implement too.

from bulmaswatch.

raniesantos avatar raniesantos commented on May 23, 2024

If you're busy I can just make a PR if you confirm you'll merge it.

from bulmaswatch.

jenil avatar jenil commented on May 23, 2024

I'm not sure if _theme-font.scss is a good idea for such a small thing. If you can make a PR with a Sass conditional variable like $enable-custom-fonts: true !default which can control the @import then it might work.

from bulmaswatch.

raniesantos avatar raniesantos commented on May 23, 2024

I guess you're right, both solutions are simple anyway. I might do it tomorrow morning.

from bulmaswatch.

raniesantos avatar raniesantos commented on May 23, 2024

I've created the PR.

from bulmaswatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.