Comments (7)
cool, will review it over the weekend
from bulmaswatch.
I'm not sure what the issue is. Both the fonts load and both can be applied using respective CSS right?
Are you saying you just want to optimize the loading by just 1 web request for fonts?
from bulmaswatch.
Are you saying you just want to optimize the loading by just 1 web request for fonts?
Yes, that's exactly what I'm trying to do. I know following PageSpeed isn't absolutely necessary but I just want to clear some of the warnings. The way the themes are setup prevent me from being able to.
Solution no. 2 seems easy enough to implement too.
from bulmaswatch.
If you're busy I can just make a PR if you confirm you'll merge it.
from bulmaswatch.
I'm not sure if _theme-font.scss
is a good idea for such a small thing. If you can make a PR with a Sass conditional variable like $enable-custom-fonts: true !default
which can control the @import
then it might work.
from bulmaswatch.
I guess you're right, both solutions are simple anyway. I might do it tomorrow morning.
from bulmaswatch.
I've created the PR.
from bulmaswatch.
Related Issues (20)
- Markdown white font and white background
- Documentation: Navbar Dropdown on "Help" page has incorrect text colors HOT 1
- How is the status of `@imort` deprecation and replace to @use/@forward?
- bookmarklet use HOT 2
- New tagged release? HOT 1
- Why $primary has !default ?
- Upgrade to Bulma v1 HOT 1
- wrong dropdown behavior in materia theme's navbar HOT 1
- ReferenceError: primordials is not defined on yarn start on Node v12.14 HOT 1
- Input text is hardly visible in dark themes by default HOT 5
- Is it v0.9 compatible? HOT 10
- Using px in darkly theme should be discouraged HOT 4
- Problem with click icon in b-input and b-autocomplete
- $navbar-breakpoint issue HOT 2
- is-size-7 doesn't seem to work on a span element
- notification light version
- Navbar minor issues since PR #77
- Select box ::after arrow too far right
- Progress bar background differs between Firefox and Chrome HOT 1
- Include All UI element of Bulma v0.9.3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bulmaswatch.