add support for agents connecting via websockets

[jenkinsci]

add support for agents connecting via websockets

[11000100111000]

I'd like to work on this issue

[torstenwalter]

Let me know of you need any help.

[11000100111000]

currently facing the error message io.jenkins.remoting.shaded.javax.websocket.DeploymentException: protocol = socket host = null which doesn't really makes sense to me since when using webSocket: false it works without a problem.

Does something change here for the agent when using the websocket flag?

[torstenwalter]

Could you create a Draft PR? That would help to look into it.

Did you change the agent port (8080 instead of 50000)?

[11000100111000]

That's probably it! I'll try out today and create the pr tomorrow if everything works

[11000100111000]

I misunderstood your last comment.
I didn't change anything about the ports(and i don't see how to create a draft but my changes are linked anyways)

[torstenwalter]

Where do I find your changes?

[11000100111000]

https://github.com/11000100111000/helm-charts/commit/b93c5c26d954d74d32e9a701e61139b316cf618e
For me they are linked in this thread ^^

[torstenwalter]

I missed that. For me this looks good. Left some small comments. The only things missing:

• bump the chart version
• add an entry in CHANGELOG.md
• optional, but very much appreciated a short documentation about that setting the README.
  That could include a link to https://www.jenkins.io/blog/2020/02/02/web-socket/

You can create a PR for it. Draft PR is just a normal PR the only difference is that while creating a PR you select draft. That indicates that it's not ready for review, yet. The benefit is that you see the results from the CI pipeline already.

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request#creating-the-pull-request Point 6 shows how one can select draft.

https://github.blog/2019-02-14-introducing-draft-pull-requests/

PS: Feel free to create the PR as part of https://hacktoberfest.digitalocean.com/

[11000100111000]

There is still the issue that the agents can't connect so yeah :/