Giter Site home page Giter Site logo

Comments (4)

skundrik avatar skundrik commented on July 26, 2024 1

Perhaps it would be better to have another issue to allow for discussion on how the dynamic service naming might work and perhaps include the service.environment as well.

from opentelemetry-plugin.

skundrik avatar skundrik commented on July 26, 2024

What about having multiple options?

  1. Manually specified, defaulting to "jenkins" as is now
  2. Dynamic based on URL using something like grok to extract parts you want and combine them into service name

from opentelemetry-plugin.

v1v avatar v1v commented on July 26, 2024

thanks @skundrik for the feedback.

for 1) I've got something in place, see #97

for the 2), would you mind if I ask you to elaborate a bit more how you foresee it?

Thanks

from opentelemetry-plugin.

v1v avatar v1v commented on July 26, 2024

I wonder, do we want to close this issue as done after merging and release #97? Or keep it open for the proposal for the dynamic based on URL?

from opentelemetry-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.