Comments (25)
It's fine to not have a pypi package.
I would add a test section to the recipe (it can be as simple as an import test).
Once a release has been made here, submit your PR to conda forge and ping me there, I will review it.
from xyz2mol.
How can I install it to my conda enviroment to use the xyz to mol function?
from xyz2mol.
@charnley Would you be ok adding a git tag to the repo? It's all I need to make a conda package out of it.
from xyz2mol.
The feedstock and conda forge package are now available.
Just install with conda install -c conda-forge xyz2mol
.
from xyz2mol.
ping @jhjensen2
from xyz2mol.
Releasing it on PyPI doesn't make sense, as it depends on rdkit which is a conda-only package. It is on the todo list to add xyz2mol to conda.
from xyz2mol.
Yeah you're right. In that case a simple git tag will do the job (with a setup.py file). From that I am happy to build the conda recipe for you and add you as a maintainer.
from xyz2mol.
Sounds good. I'll setup the setup.py
in the weekend. I anyway want to update the repo with pre-commit. Do you have an example GitHub action for conda releases?
from xyz2mol.
To be more specific a conda package is a conda package on the conda forge channel. This anaconda channel is managed by an open community (not the anaconda company).
The process to create such a package is to create a git repo called a feedstock. This repo contains all the logic to build and upload a package from the source code.
Python libraries are automatically updated whenever a new pypi release is made. This is why I was proposing to release a pypi package of xyz2mol. Since it will allow conda forge to automatically build a new package whenever it detects it. The fact that it depends on rdkit is not a big deal as long as you highlight it on the README and propose conda as the primary way to install it.
You can find more information about the whole process on the doc: https://conda-forge.org/docs. You don't have to master conda forge right now as I am happy to take care of this for you and you'll catch up later whenever you have time for this.
Feel free to ask more questions here.
from xyz2mol.
I don't like adding xyz2mol to pypi, as the package will not work if users install it via pip. The users who won't understand why will probably not read a readme.
I've added the following meta.yaml to the recipe https://github.com/jensengroup/staged-recipes/tree/xyz2mol/recipes/xyz2mol
And currently working on a pull-request with setup.py and automatic releases via git tags https://github.com/charnley/xyz2mol
Comments are welcome on my conda-forge usage.
from xyz2mol.
Friendly ping here. Just a simple git tag will do the job. I can do the rest.
from xyz2mol.
I would also be interested to have this amazing module as a package on conda.
from xyz2mol.
rdkit is now available on pypi (as rdkit-pypi), so nothing prevents it from being released on pypi as well
from xyz2mol.
«as it depends on rdkit which is a conda-only package»
It doesn't look so. DebiChem repackages RDKit for Debian (tracker) for multiple years, thus it equally is available for relatives like the Ubuntu family (tracker). Apparently, likewise Fedora repackages RDKit (tracker), too. Depending on the intended work ahead, the lag between them and the releases for conda may be significant, or not. E.g., with RDKit 2021.09.2 as provided by Debian 12/bookworm (testing), the commit by 2020-11-26, 08:36 (cf. here) xyz2mol actually seems to work just as intended.
from xyz2mol.
Sorry for the radio silence on this, but I finally have a bit of time to look at this. I am happy to have conda and pip installs (if it's not too much work on my part) but I know nothing about it and need someone to guide me through the steps
from xyz2mol.
@jhjensen2 if you can create a git tag or release on the repo with a semver version (something like 0.1.0
or 1.0.0
) then I can start the conda package creation process and ping you along the way, so you can see what is happening. I will also add you as a maintainer of the package, so you'll have full control over it.
To create a release on GH, see https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository
from xyz2mol.
We will also need a setup.py
file as in #24
from xyz2mol.
I don't understand the last comment or what's in the link. What should go in the file?
I've made a release, but should I have made the setup.py file first?
from xyz2mol.
To be able to install the library, a setup.py
file need to be added to the repo. The one from https://github.com/jensengroup/xyz2mol/blob/b86529f15f7a9fc728002adb17739c930c5f8bce/setup.py should do the job . Adapt the version string in the file to 0.1.1
and then create a new release for 0.1.1
.
from xyz2mol.
OK, done
from xyz2mol.
The setup.py file is empty: https://github.com/jensengroup/xyz2mol/blob/master/setup.py
from xyz2mol.
oops, fixed
from xyz2mol.
You now need to release 0.1.2 (and make sure to edit the version in setup.py too). We're almost there!
from xyz2mol.
done!
from xyz2mol.
The package recipe is being reviewed at conda-forge/staged-recipes#17412
from xyz2mol.
Related Issues (20)
- Purpose of 1.3 multiplier in checking covalent bonds HOT 2
- Stranger case when convert xyz file to mol HOT 5
- missing support for boron atoms HOT 1
- Problem with assignment of charges HOT 4
- 'charge_OK' referenced before assignment HOT 1
- Exceptionally long runtime for a few organic structures from materials project HOT 7
- Failure for Ruthenium complexes HOT 2
- `--sdf` argument HOT 1
- Valence greater than 4 HOT 1
- typo? HOT 2
- NameError: name 'defaultdict' is not defined HOT 5
- Parsing nciatlas geometries HOT 1
- Add UserWarning for incorrect charge?
- atomic valence of O atom inconsistent with RDkit HOT 2
- Convert xyz file with several structures in it (different molecules or same molecule, conformers) HOT 2
- how does this relate to rdkit.Chem.rdmolfiles.MolFromXYZBlock and rdkit.Chem.rdmolfiles.MolFromXYZFile ? HOT 1
- Propyl radical gives empty list of molecules HOT 4
- sdf file is empty while converting from xyz file HOT 12
- Comparison with OpenBabel?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xyz2mol.