Comments (3)
@UnrulyNatives I guess some users use Jenssegers in sentences where months are not in Genitive. So for them, your fix breaks their workflows.
So what we really need to do is providing a way to apply the Nominative/Genitive dynamically as moment.js do:
https://github.com/moment/moment/blob/develop/locale/pl.js
Can you check if moment.js function is right. Then if it is, please propose a pull-request to Carbon:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/pl.php
Carbon 2 handle dynamic cases, for example, ru.php take months_standalone instead of months when the format (considered with the isoFormat() method pattern) matches the months_regexp:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/ru.php#L169
from date.
I checked with moment.js and planned to do this:
kylekatarnls/Carbon@4c167aa
That would be the correct way to handle it. Else you will always have someone that get an incorrect result for his own case.
from date.
Fixed in 4.0.0.
from date.
Related Issues (20)
- [QUESTION] What is the language name of each file? HOT 4
- Adding Kurdish Language (cks) HOT 4
- Function translateTimeString() translate part of the word if translations are overlapping HOT 1
- Khmer Language Please HOT 2
- Support Carbon 2 ?! HOT 8
- Use Symfony\Contracts\Translation\TranslatorInterface instead of Symfony\Component\Translation\TranslatorInterface HOT 4
- BUG: Russian translation of the month HOT 3
- A small error in the Turkmen locale. HOT 2
- Return incorrect month format in "ru" & "uk" translations after call ->format('M') HOT 6
- [QUESTION] How to add custom lang file without adding it to vendor folder? HOT 1
- Usage of deprecated Symfony methods to translate and format HOT 4
- defualt value to be null. HOT 1
- Support Laravel 7 HOT 12
- Date::parse('February')->month returns 3 HOT 2
- Translator does not implement HOT 5
- Italian short version on may shows full month name HOT 8
- Return incorrect ordinals numbers to fr_CA HOT 1
- ADD recognize weeks HOT 3
- Arabic numbers support HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from date.