Giter Site home page Giter Site logo

Comments (3)

kylekatarnls avatar kylekatarnls commented on August 21, 2024

@UnrulyNatives I guess some users use Jenssegers in sentences where months are not in Genitive. So for them, your fix breaks their workflows.

So what we really need to do is providing a way to apply the Nominative/Genitive dynamically as moment.js do:
https://github.com/moment/moment/blob/develop/locale/pl.js

Can you check if moment.js function is right. Then if it is, please propose a pull-request to Carbon:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/pl.php

Carbon 2 handle dynamic cases, for example, ru.php take months_standalone instead of months when the format (considered with the isoFormat() method pattern) matches the months_regexp:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/ru.php#L169

from date.

kylekatarnls avatar kylekatarnls commented on August 21, 2024

I checked with moment.js and planned to do this:
kylekatarnls/Carbon@4c167aa

That would be the correct way to handle it. Else you will always have someone that get an incorrect result for his own case.

from date.

kylekatarnls avatar kylekatarnls commented on August 21, 2024

Fixed in 4.0.0.

from date.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.