The possibility of adding new features

[jeremybarbet]

The possibility of adding new features

[Angelk90]

@jeremybarbet :
What do you think you can add the following feature.

[jeremybarbet]

Are you talking about the modal that "merges" with the status bar?

If so, it would definitely be a good addition, I'm not sure how it would work, maybe a boolean, that you can either pass at true or not, to get this behavior.

I'm quite busy lately, I'll add it to the backlog, but I won't be able to work on that in the coming days.

[jeremybarbet]

Hey,

1. I think you forget the alpha channel: rgba (0,0,0,0).
2. That's a good idea to have gradient as a background. I'll add it on the backlog of the project

[Angelk90]

@jeremybarbet :
1)I tried both with rgb and rgba, it does not work, it only works with "#color".
If you do not believe me, see here: https://snack.expo.io/SkSxTKk7N

3)The ability to choose whether to set the opacity and transparency of everything else to better understand, look at the image.

[Angelk90]

@jeremybarbet : You could take a look at this example, I used your lib, I wanted to ask you if it's normal to get this result: https://snack.expo.io/ryqbRGbXN

a) As you can see I put handlePosition = "inside", inside I put a View with a Text inside, but overlap, I could use a marginTop inside, but in my opinion it should not happen that it should overlap the borderRadius.

b) As you can see by setting an opacity in modalize__content, it would be advisable to remove elevation: 4, it makes a strange effect.

c) Inside Modalize.tsx, I suggest you put in line 680 and 716, {borderRadius: 0}, as I put it, if the user sets it by mistake or otherwise, both have a strange effect.

d) It would be interesting also the possibility not to put a handlePosition for example handlePosition = "none"

e) there is a way to know at all times the exact height of the Modalize, I do not know a props that returns at any moment the height as soon as it moves?

Let me know what you think?

[jeremybarbet]

@jeremybarbet :
1)I tried both with rgb and rgba, it does not work, it only works with "#color".
If you do not believe me, see here: https://snack.expo.io/SkSxTKk7N

3)The ability to choose whether to set the opacity and transparency of everything else to better understand, look at the image.

1. You did a typo on the snack link, it's rgb or rgba.

2. You can definetly define a transparency to the background of the modal if you want by doing style={{ opacity: 0.6 }} (cf: there is an example of custom style on this exemple: https://github.com/jeremybarbet/react-native-modalize/blob/master/examples-shared/src/components/modals/CustomStyle.tsx)
   About the gaussian blur, I would need to add a dependencie to make it works. It's not a bad idea, i'll add it on the backlog.

@jeremybarbet : You could take a look at this example, I used your lib, I wanted to ask you if it's normal to get this result: https://snack.expo.io/ryqbRGbXN

a) As you can see I put handlePosition = "inside", inside I put a View with a Text inside, but overlap, I could use a marginTop inside, but in my opinion it should not happen that it should overlap the borderRadius.

b) As you can see by setting an opacity in modalize__content, it would be advisable to remove elevation: 4, it makes a strange effect.

c) Inside Modalize.tsx, I suggest you put in line 680 and 716, {borderRadius: 0}, as I put it, if the user sets it by mistake or otherwise, both have a strange effect.

d) It would be interesting also the possibility not to put a handlePosition for example handlePosition = "none"

e) there is a way to know at all times the exact height of the Modalize, I do not know a props that returns at any moment the height as soon as it moves?

Let me know what you think?

a) I still don't know what behavior developers expect the most: no style at all and they have to do it by themselves, already a padding but won't it be annoying for some people?

b) you can overwrite modalize__content's style by doing

style={{ elevation: 0 }}

c) You can do the same by doing

style={{ borderTopLeftRadius: 0, borderTopRightRadius: 0 }}

and

overlayStyle={{ borderRadius: 0 }}

d) There is a prop for that: withHandle https://jeremybarbet.github.io/react-native-modalize/#/PROPSMETHODS?id=withhandle

e) Why do you want the heigh of the modal, can you give me more context about it? You can try doing this, but I haven't try if it works:

this.modalize.current.measure((x, y, width, height, px, py) =>
  console.log(x, y, width, height, px, py);
);

[Angelk90]

@jeremybarbet :
Look at this example I think you'll understand better: https://snack.expo.io/ryjXUYZQN

What I wanted to do is give the possibility that in addition to having the modelize only backgroundColor give the possibility to have:

• an image as background
• a color gradient as background
• the blur effect as a background

For example for the gradient, I was thinking of using rn-gradients which is done in js but for performance issues it does not seem to be good.
So I was trying the usual gradient: react-native-linear-gradient that on expo can not be installed but has its own version, however.

The effect for the gradient in my opinion must be so, starting from the initial position of the height set, when changing the position of the modelize, must also vary the height of the gradient, otherwise some colors I speak of the final parts will not be visible.
So at each move of the modalize to stabilize the gradient must update, then via a setState ();

I was thinking of using something like this: https://stackoverflow.com/a/50684433

But I'm not able to figure out where the correct position is, if it works and the performance is not too low.

P.Š.
One problem I've noticed is that if I set HeaderComponent, and swap to the other where HeaderComponent is located, it will not let me do that?
is it a normal behavior?

Let me know what you think.

[jeremybarbet]

Yes none of this features are supports yet. I want a stable version before adding new feature as such, even though I added it in the backlog.

P.Š.
One problem I've noticed is that if I set HeaderComponent, and swap to the other where HeaderComponent is located, it will not let me do that?
is it a normal behavior?

I didn't understand your question

[Angelk90]

@jeremybarbet : You have the last example that I posted to expo.io, take it, now you do as if you had to climb up to make sure that modalize take the whole screen, you have to take but from where there is HeaderComponent in its entirety or try to take it from the handle. He can not get up. I do not know if I explained myself well.

[jeremybarbet]

Yes, I'm aware of this, this is related to: #23

[Angelk90]

@jeremybarbet :

I'm talking about that, I think something like that can be good, like boolean.

[jeremybarbet]

I'll close this issue. All your ideas have been added to the backlog and I will work on it in the future when I have time.