Giter Site home page Giter Site logo

Comments (10)

nwaughachukwuma avatar nwaughachukwuma commented on August 22, 2024 1

Ok cool. Would send in something for review ASAP. Thanks

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

Hi!

That's totally correct, there is no way now to know if the modal is open or not. I don't have time to work on it but feel free to open a PR and I'll be happy to review it!

Here are the part of the code you would need to change to add a boolean:
https://github.com/jeremybarbet/react-native-modalize/blob/master/src/Modalize.tsx#L231-L235
https://github.com/jeremybarbet/react-native-modalize/blob/master/src/Modalize.tsx#L392

from react-native-modalize.

nwaughachukwuma avatar nwaughachukwuma commented on August 22, 2024

@jeremybarbet is there an update on this? I can make a PR for this is it's not been done

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

@nwaughachukwuma Hi! No work have been done yet. Feel free to create a PR!

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

@nwaughachukwuma That would be awesome!

from react-native-modalize.

nwaughachukwuma avatar nwaughachukwuma commented on August 22, 2024

Hi!

That's totally correct, there is no way now to know if the modal is open or not. I don't have time to work on it but feel free to open a PR and I'll be happy to review it!

Here are the part of the code you would need to change to add a boolean:
https://github.com/jeremybarbet/react-native-modalize/blob/master/src/Modalize.tsx#L231-L235
https://github.com/jeremybarbet/react-native-modalize/blob/master/src/Modalize.tsx#L392

Hi @jeremybarbet, these links are dead

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

if (onOpened) {

And something around these lines

private onHandleChildren = ({ nativeEvent }: PanGestureHandlerStateChangeEvent): void => {

from react-native-modalize.

nwaughachukwuma avatar nwaughachukwuma commented on August 22, 2024

Ok thanks

from react-native-modalize.

nwaughachukwuma avatar nwaughachukwuma commented on August 22, 2024

@jeremybarbet pull request made at #122. Please follow-up

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

Version 1.3.7-rc.2 has a new props to get the current position of the modal. https://jeremybarbet.github.io/react-native-modalize/#/PROPSMETHODS?id=onpositionchange

from react-native-modalize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.