Giter Site home page Giter Site logo

Comments (7)

jeremybarbet avatar jeremybarbet commented on August 22, 2024 26

If I get you right, I think it's because you didn't use the props withReactModal, it's false by default.

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

I'll close this issue, feel free to re-open it if needed.

There are more details about it here: https://jeremybarbet.github.io/react-native-modalize/#/PROPS?id=withreactmodal

I'll add in the future examples for both react-navigation/react-native-navigation

from react-native-modalize.

waheedakhtar694 avatar waheedakhtar694 commented on August 22, 2024

Hi @jeremybarbet,
I wanted to open a fullscreen modal that covers the whole screen but as mentioned in the docs withReactModal props breaks on android so I implemented in this way as the discussion here.
#68
But two issues I am facing right now.

  1. One is the tabs as you can see I rendered Modal on top of the tabs and tried with a higher number of zIndex but it's still below the tabs.
  2. I wanted to remove white space behind the green background while scrolling, As you see in the gif below, Sometimes it appears and sometimes not.

Modal

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

Hi,

As you will be able to see here https://jeremybarbet.github.io/react-native-modalize/#/PROPS?id=withreactmodal, react's modal is now working with Android thanks to a fix made in react-native-gesture-handler.

Even though, if you want to display Modalize on top of your bottom tabs you can follow also this example: https://jeremybarbet.github.io/react-native-modalize/#/EXAMPLES?id=react-navigation

from react-native-modalize.

waheedakhtar694 avatar waheedakhtar694 commented on August 22, 2024

@jeremybarbet I manage to display modal above the tabs but the problem now is some touch events do not works inside the modal, I have a react-native-video and it has native controls inside the modal controls does not work especially play/pause.

from react-native-modalize.

jeremybarbet avatar jeremybarbet commented on August 22, 2024

@appify-waheed It's most likely related to this issue #52. Can you create a https://snack.expo.io that reproduce your issue?

from react-native-modalize.

waheedakhtar694 avatar waheedakhtar694 commented on August 22, 2024

@jeremybarbet Here is a snack I have placed with two video players one is inside the modal and the other is outside the modal, Controls works outside but inside not.
https://snack.expo.io/@waheed25/ashamed-tea
Also, I have felt sometimes a problem while closing the modal when it covers the full screen having scrollview inside, When we are scrolling and then try to close the modal sometimes it closes on 3rd or 4th attempt.

from react-native-modalize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.