Comments (3)
Thanks seriouslagg for sharing the issue and the patch.
If you can share the code for repro (ofcourse not the actual proprietary code
but some sample representative code which can reproduce the issue with just the
offending styling and dummy logic) then it can be added in the test suite to
avoid regression.
Original comment by [email protected]
on 12 Nov 2013 at 6:18
from closure-linter.
Over the past few days I've been trying to produce a usable testcase for
this purpose, but unfortunately I have yet to strip it down in a way that
both reproduces the error and doesn't violate the terms of the agreement.
It's related to syntax in the files themselves used for preprocessing that
chokes up gjslint. I'll see what can be done about writing a testcase from
scratch.
Original comment by [email protected]
on 12 Nov 2013 at 9:32
from closure-linter.
Attached is a patch that adds the unit test.
Original comment by [email protected]
on 12 Nov 2013 at 10:43
Attachments:
from closure-linter.
Related Issues (20)
- e between function and bracket HOT 1
- Exlusion for fixjsstyle-script.py does not work correct on Windows OS
- Using 'default' keyword as object identifier causes silent exit HOT 1
- linter ignores @suppress {visibility} HOT 1
- please use git
- Member variables ending with '_' are not required to have @private JsDoc when declared inside goog.scope.
- Skip "marked" lines HOT 2
- "missing semicolon" when calling a method on a function definition HOT 1
- incorrect "else" block warning
- var x = {a: b;}; Unable to check the rest of file. Error "None"
- Add Python 3 support
- whitespace around line comments not enforced
- Semicolon is added incorrectly after some function definitions HOT 1
- Doesn't allows Object parameter description, using multiple params HOT 3
- Node/Angular Promise catch method error "missing space before ("
- Support template string literals and single quote
- adds illegal semicolon when a function is assigned to a variable in the middle of statements
- Invalid suppression type: reportUnknownTypes HOT 1
- Up to date release tarballs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from closure-linter.