existingConfigMapName is not working for ProxyFleet

[stevefan1999-personal]

existingConfigMapName is not working for ProxyFleet

[jeremylvln]

Hi @stevefan1999-personal!

Thanks a lot for reporting the issue. The configuration field was present but was not used at all for the proxies. I've opened a PR to fix it. Let me know once merged & built if it fixes your issue (use the next image tag for the operator) :)

[jeremylvln]

It's currently a total overwrite you are write. I can't cherry-pick parts of the ConfigMap, I really want to keep this on the Kubernetes-level by changing the name of the ConfigMap. However I understand it could be an issue. Maybe it would be useful to split the ConfigMap to isolate the bootstrapping scripts from the config files themselves.

[TehNeon]

I may have attempted to utilize this feature incorrectly. But it sounds like it's meant to allow for the overriding of the config map that provides the proxy config (velocity-config.toml as defined in the Shulker provided configmap). But in actual usage, it appears that it wants theinit-fs.sh file to be defined in the config map, also likely other files like the probe-readiness.sh. I'm not sure if this is the intended behaviour to allow for the overriding of the init-fs.sh.

[github-actions]

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on:

• v0.8.0
• v0.8.0
• GitHub release

Your semantic-release bot 📦🚀

[stevefan1999-personal]

Not working for MinecraftServerFleet either

Shulker/packages/shulker-operator/src/reconcilers/minecraft_server_fleet/fleet.rs

Lines 59 to 61 in 5937788

	let mut config_clone = minecraft_server_fleet.spec.template.spec.config.clone();
	config_clone.existing_config_map_name =
	Some(ConfigMapBuilder::name(minecraft_server_fleet));

@jeremylvln

[jeremylvln]

Jeez. Nice catch. I totally forgot about the fleet. Will fix shortly.

Thanks!