Giter Site home page Giter Site logo

Comments (5)

jerrypnz avatar jerrypnz commented on September 24, 2024

No it's not possible currently but it seems nice to have. I'll have a think about it.

from major-mode-hydra.el.

hubisan avatar hubisan commented on September 24, 2024

Had a look at the code. Something like this should do it:

Handle :separator different if it is a list like ("-" " ") and use the cdr as the separator between columns like so:

  1. Change pretty-hydra--gen-heads-docstring

    (s-pad-right width separator ""))

    Add this to let of the function:

    (separator (or (and (listp separator) (car separator)) separator))

    And change the line above to this:

    (s-pad-right width separator "^^"))

    (Note: with the old code the separator is as it looks actually too wide. Is this on purpose?)

  2. Change pretty-hydra--gen-heads-docstring

    (s-join (if (= i 1) "" " ")

    Add this to let of the function:

    (separator (or (and (listp separator) (cadr separator)) separator))
    (col-separator (s-pad-right (length separator) " " ""))

    And change that line to:

    (s-join (if (= i 1) separator col-separator)

Like this one can even use a separator longer than one character :separator ("─" " │ "):

image

What you think? I can make a pull request. Would this also affect the tests?

from major-mode-hydra.el.

jerrypnz avatar jerrypnz commented on September 24, 2024

Oh I thought you'd want the column separator to appear on every row, not just the separator row. If this is really what you want, your proposed solution sounds good to me (otherwise I'd probably introduce a separate property :col-separator).

A PR is definitely welcome!

from major-mode-hydra.el.

hubisan avatar hubisan commented on September 24, 2024

had time to work on this:
https://github.com/hubisan/major-mode-hydra.el/tree/feature/col-separator

:col-separator a string or a list of two strings used to separate the columns. If it is a list, the second string is used as column separator at the separator line. If the strings in the list are of unequal length the shorter string is centered by adding spaces.

So this accepts " │ " or '(" │ " "───"). If a list the effect is the following, using '("x│x" "=X="):

image

Added a .travis.yml for automated testing against emacs 25 and 26. Test in 25 unfortunately fail, caadr and caaddr (used in pretty-hydra--normalize-args) were introduced in emacs 26. Can you change this on develop? Will rebase, add some tests for the :col-separator and make the pull request.

from major-mode-hydra.el.

jerrypnz avatar jerrypnz commented on September 24, 2024

@hubisan That's awesome! Looking forward to your PR.

from major-mode-hydra.el.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.