Ability to replace card detection method

[jessepollak]

Ability to replace card detection method

[jessepollak]

How do you envision this working? What would the function return?

[Zakay]

Just a rough example on how this could work:

$('form').card({
    ...
    detection: function (card_number) {
       return card_number == '123' ? 'visa' : 'mastercard';
    }
    ...
});

Card will use given detection method when given otherwise using the built-in one.
This way developers could easily hook in other detection methods, in my case I would hook stripe's js lib here to return the correct card type.

[jessepollak]

It uses Stripe's jquery.payment library right now to do the detection. That said, if you'd like to submit a PR, I'd be happy to merge it in.

[lipis]

Totally worth reading and there is no need to use something that complicated like jquery.payment: http://creditcardjs.com/credit-card-type-detection

[Zakay]

The suggestion was not to diss or praise any detection algorithm. Just simply to add the possibility to connect this "view" to whatever detection algorithm is used by the payment provider.

Because it uses Stripes jquery.payment I won't be needing it just now, but maybe in the future. Will see!

[quedicesebas]

I'm with @lipis

[Zakay]

With a detection callback a developer could go much further and detect issuing bank and display an even more correct view of that credit card. I already love that it shows Visa/AmEx etc, and the library shouldn't go much further, but adding an ability to override the detection method won't make the library more complex, it just adds a nice feature for those who want to go a step further and display local bank credit cards.

[jessepollak]

Hi all, thanks for your feedback! I like this idea, unfortunately, making the change requires a pretty big logic shift around how we do credit card detection. Right now, I don't have the bandwidth to make that change and there's not enough demand to motivate me to create that bandwidth.

I'm closing the issue for now. If you'd like to create a PR to make the change, I would love to support you in making that happen (especially if you've never contributed before). I'm always around to help answer questions.