Addition: lowercase-name only for tests

[jest-community]

Addition: lowercase-name only for tests

[macklinu]

We could provide an option that allows for ignoring the check for describe().

{
  "jest/lowercase-name": ["error", {
    "ignore": ["describe"]
  }]
}

I'm also wondering if lowercase-name should check describe() at all, or if only checking it() and test() is more valuable. 🤔

[nevir]

There's also advice like "don't start test descriptions with 'should'" and similar things. Idea: what if there's an option to provide a regex (or multiple) that can be used to validate tests (and a similar option for describes)?

…

On Mon, Feb 12, 2018, 7:32 PM Macklin Underdown ***@***.***> wrote: We could provide an option that allows for ignoring the check for describe(). { "jest/lowercase-name": ["error", { "ignore": ["describe"] }] } I'm also wondering if lowercase-name should check describe() at all, or if only checking it() and test() is more valuable. 🤔 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#76 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAChnaaCyhed2pPTzOwQ03Ce6ncUjYJNks5tUQJHgaJpZM4SDJrS> .

[SimenB]

I like the idea of a regex (and an ignore array). PR welcome for both!

[macklinu]

This code introduced in #74 could be a starting point for introducing an ignore option to the lowercase-name rule.

eslint-plugin-jest/rules/no-hooks.js

Lines 30 to 35 in 47eb6c2

	const whitelistedHookNames = (
	context.options[0] || { allow: [] }
	).allow.reduce((hashMap, value) => {
	hashMap[value] = true;
	return hashMap;
	}, Object.create(null));

[with-heart]

I submitted a PR to add the ignore option for this rule. I started to do some work on regex but it doesn't really feel like the description message regex belongs in the lowercase-name rule. Thoughts?

[nevir]

maybe rename the rule to name, naming-style or something along those lines?

[SimenB]

Renaming it is a breaking change... We have a few breaking changes lined up anyways, so not a blocker. Worth it, though?

[nevir]

Unsure! could maybe duplicate it into the new name & deprecate old, if you want a smoother transition (but a bit more annoying to maintain)

[SimenB]

This should be covered by the new option, agreed @nevir?

Might be worth opening up a new issues for renaming the option. My vote is for a new major once node 4 is EOL in April anyways 🙂

[SimenB]

🎉 This issue has been resolved in version 21.15.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀