StreamNotFoundException when trying to add Events to a new Stream with EventStoreDb

[keppelerj]

StreamNotFoundException when trying to add Events to a new Stream with EventStoreDb

[bartelink]

Hi, thanks for the detailed issue and apologies for you having to encounter it.
I don't have an environment to hand to verify this (it only needs the ESDB config from the docker-compose config in this repo), but 99% sure this got broken in the TaskSeq port recently (code with async got changed to task, and there are variances regarding how the various await mechanisms wrap exceptions). I'd be surprised if it's an ESDB Client or Server issue.
Most likely the test suite is failing too (if it's not, then it should definitely cover this case).
Would definitely appreciate a PR - can get a fresh nuget released right away after that

[keppelerj]

Hi @bartelink! Thanks for the quick response. I just tried running the test suite for esdb (StoreIntegration.fs is the one right?) and indeed, it fails.
Yep looks like you are right, it's because of the TaskSeq port. Removing the wrapping of the exception fixes the issue and all tests pass :) I'll provide a PR. A new nuget release would be awesome!

[bartelink]

Excellent, thank you!
Need to go afk now; will review the PR in full later
Main thing that sticks out for now is that I'd prefer to stick with the = thtask { on the previous line as per the rest of the repo - I appreciate that's non-standard, but mixing styles is even worse ;)
(If you'd prefer for me to apply style tweaks myself afterwards, rather than doing a to/fro exercise, let me know either)

[keppelerj]

Yes fully agree with you! Mixing code styles is a nightmare :D
Do you have a "formatting/style guide" file that I can plug into my IDE by any chance?
Changed it by hand now but usually I let my IDE format the code for me.

[bartelink]

Unfortunately the code formatting is mainly manual. There is a .editorconfig (which is very sparse) - open to improvements on that but in general the aim would be to have any proposed rules immediately be consistently applied, which makes it a non-trivial task. In general the = task { on the previous line (and closing brace on last line) is the key thing that deviates from typical conventions in the F# style guide.

Einar took a run at applying Fantomas in #345 - that might be more viable had it [existed and] been used from the start - in general its rules would likely encourage pulling out more helpers etc