Giter Site home page Giter Site logo

Comments (7)

juliabeliaeva avatar juliabeliaeva commented on May 27, 2024 1

I can send a PR with the feature reimplemented with the new VcsLogCustomColumn api. The downside of this api is that custom columns are enabled by default, which is different from the current implementation. This could be surprising to the users, so I'm not sure if this is the right change to make.

Here is the screenshot of log tab with the new column:
image
The new api creates actions to enable columns in the "Show Columns" menu, so the custom action will be no longer needed (not sure if "Detected Refactorings" is good column name, suggestions are welcome):
image

from refactorinsight.

juliabeliaeva avatar juliabeliaeva commented on May 27, 2024 1

Is there no other way to add the column and show it only if the user wants to see it?

I don't know any. We can add api for it in the next version (2021.1).

from refactorinsight.

juliabeliaeva avatar juliabeliaeva commented on May 27, 2024 1

Api was added to 2021.1: JetBrains/intellij-community@aabbc19

from refactorinsight.

onewhl avatar onewhl commented on May 27, 2024

@juliabeliaeva, it looks good, thank you! To be clear, we will add the information about this feature with a screenshot to README.

from refactorinsight.

juliabeliaeva avatar juliabeliaeva commented on May 27, 2024

The downside of this api is that custom columns are enabled by default, which is different from the current implementation. This could be surprising to the users, so I'm not sure if this is the right change to make.

@onewhl, Just to clarify, do you think it's ok to display the refactoring labels by default?

from refactorinsight.

onewhl avatar onewhl commented on May 27, 2024

@juliabeliaeva I see, that indeed might be confusing for the users. Is there no other way to add the column and show it only if the user wants to see it?

from refactorinsight.

onewhl avatar onewhl commented on May 27, 2024

@juliabeliaeva that's great, thank you!

from refactorinsight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.