Comments (3)
Thanks for getting in touch. Let me summarize my thoughts from our DM here.
suggestion would be remove the fallback on LocalViewModelStoreOwner for KMP targets (jbMain)
I believe this should be the same across the platforms
This is where it depends on Compose UI
Yes, but Android depends on UI only in similar line too.
I don't see why it can't have dependency in viewmodel-compose
This module will bring dependency not only to itself - it has dependencies that UI doesn't. We'd like to avoid extra dependencies in Compose UI module.
My suggestion here is to open an issue in Google's tracker and try to do such a revert in AOSP first.
I already made this change for compose-ui and lifecycle-compose for the same reason, so I suspect a similar change could be made here.
Yep, thanks for that. But I guess there the situation is a bit different - it really depends on UI part in terms of finding UI view as default provider. My best guess here at the moment is to extract the required part rom ui
to separate ui-something
module and depend only on that.
Anyway, I'm going to close it as not planned for now, since I believe that it should be done in AOSP first. Please post a link to the issue in AOSP once created.
from compose-multiplatform.
@DevSrSouza, could you please open an issue in our AOSP lifecycle issue tracker so we can investigate this further? Please cross-link both issues for additional context and easier tracking. Thank you!
from compose-multiplatform.
The dependency between compose-ui and viewmodel-compose should likely be inverted. I already made this change for compose-ui and lifecycle-compose for the same reason, so I suspect a similar change could be made here.
from compose-multiplatform.
Related Issues (20)
- 1.6.10 depends on pre-release versions of Kotlin HOT 1
- Desktop: Fails to createDistributable with packageDmg because of duplicate entry: META-INF/services HOT 1
- Reduce ios app size. HOT 5
- [Web] Uncaught runtime error in Material3 DatePicker (DisplayMode.Input) when enter incorrect date
- 1.6.10 has broken the screenWidth calculation HOT 8
- CAMetalLayer ignoring invalid setDrawableSize error HOT 2
- [Resources] Any plan on supporting nine-patch drawable?
- Support arbitrary string resource ID
- Need "Start after install complete" option in configuration of windows installer HOT 2
- Font is not updated to the new font resource
- Binaryen error on Windows machine HOT 5
- Cannot change attributes of configuration ':composeApp:debugFrameworkIosX64' after it has been locked for mutation HOT 1
- Desktop. Native distribution. `intallationPath` doesn't work if `dirChooser` = false
- Reduce variety of Preview annotations HOT 5
- Being able to create a ComposePanel with vsync disabled
- Need to tap the touchpad thrice for double click action when using combined clickable. However, Button clicks are only required to clicked twice. HOT 4
- ImageVector is blurry when used with `Image()` + `Modifier.scale()` HOT 2
- [Compose Resources] commonMainResourceAccessors is not generated in multi-module architecture using Kotlin 2.0.0 HOT 4
- `Dialogs` are not rendered as expected when used inside a `ImageComposeScene`
- Unable to compile kotlinjs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose-multiplatform.