Giter Site home page Giter Site logo

Comments (2)

Tapac avatar Tapac commented on May 3, 2024 3

You are absolutely right about nullability of aggregated functions, but I think that not all of them can return null value (count for example).
I've fixed it and add your test to ensure.
Also I have changed return value of avg function to BigDecimal and it's possible to provide scale to it (test also included).

from exposed.

spand avatar spand commented on May 3, 2024

That was quick. We are not quite there yet however. It only works because you .max() on a nullable column.

This still fails:

@Test fun testGroupBy06() {
    withCitiesAndUsers { cities, users, userData ->
        val maxNullableId: Max<Int> = cities.id.max()

        cities.slice(maxNullableId).selectAll()
                .map { it[maxNullableId] }.let { result ->
            assertTrue(result.size == 1)
            assertNotNull(result.single())
        }

        cities.slice(maxNullableId).select { cities.id.isNull() }
                .map { it[maxNullableId] }.let { result: List<Int?> ->
            assertTrue(result.size == 1)
            assertNull(result.single())
        }
    }
}

I would think all of the aggregate functions should return a nullable version of their types.

Also, about the Average function there seems to be a need for changing the type.
H2 docs says: "The returned value is of the same data type as the parameter."
PostgreSQL: "numeric for any integer-type argument, double precision for a floating-point argument, otherwise the same as the argument data type"
MySQL: "The SUM() and AVG() functions return a DECIMAL value for exact-value arguments (integer or DECIMAL), and a DOUBLE value for approximate-value arguments (FLOAT or DOUBLE)."

Im not sure if what the intersection with these statements is.. but at the very least is there a way of converting from an Int column to a Double column?

from exposed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.