Giter Site home page Giter Site logo

Comments (15)

rock3r avatar rock3r commented on May 28, 2024 2

Reopened to remind me to add that notice to the readme, and hopefully to fix things in Studio dependencies so that Jewel doesn't leak to 3p plugins

from jewel.

rock3r avatar rock3r commented on May 28, 2024 1

Android Studio is not currently supported — I don't think it's supposed to ship Jewel yet, but there are some features we're working on that will use Jewel, so it may just be getting ready in advance.

To target Android Studio you currently would need to jarjar/shadow Compose and Jewel.

from jewel.

rock3r avatar rock3r commented on May 28, 2024 1

You can look at how Package Search does it — their plugin works fine in Android Studio afaik.

from jewel.

mr-thierry avatar mr-thierry commented on May 28, 2024 1

Android Studio is not currently supported — I don't think it's supposed to ship Jewel yet, but there are some features we're working on that will use Jewel, so it may just be getting ready in advance.

To target Android Studio you currently would need to jarjar/shadow Compose and Jewel.

Would it be possible to put that IN ALL CAPS AND WITH A BIG FONT SIZE in the README? 🙂
(that would have avoid me wasting a day of development)

Especially since the video in the README file is from a Droidcon talk. 😉

from jewel.

mr-thierry avatar mr-thierry commented on May 28, 2024 1

@mr-thierry does this happen on Jellyfish, too? I would expect so, since the setup is the same.

Tried with Jellyfish 2023.3.2.1 and it has the same issue

from jewel.

mr-thierry avatar mr-thierry commented on May 28, 2024 1

Follow-up on this for anyone looking for a solution to this issue:
I ended up using the Jewel component that is currently shipping with Android Studio. While the version is quite old (v0.11), it's still better than using Swing IMHO 🙂

from jewel.

rock3r avatar rock3r commented on May 28, 2024 1

I have added a note in the readme mentioning this. https://github.com/JetBrains/jewel/blob/main/README.md#branching-strategy-and-ij-platforms

Will update when there are news on the Studio side.

from jewel.

rock3r avatar rock3r commented on May 28, 2024 1

from jewel.

mr-thierry avatar mr-thierry commented on May 28, 2024

Also found this: JetBrains/intellij-platform-gradle-plugin#587

from jewel.

rock3r avatar rock3r commented on May 28, 2024

Would it be possible to put that IN ALL CAPS AND WITH A BIG FONT SIZE in the README? 🙂
That's a very reasonable request :) Sorry, I hadn't thought of it before.

To be honest, I hope we'll manage to figure out a way to avoid leaking the Jewel/Compose dependency for Studio 3p plugins. I'll see if my colleagues can find a way! Dependencies are pretty complicated beasts in the IntelliJ Platform when you look at them from the 3p plugin perspective 😓

from jewel.

rock3r avatar rock3r commented on May 28, 2024

I have filed an issue against Studio to try and sort out this dependency leak. @mr-thierry does this happen on Jellyfish, too? I would expect so, since the setup is the same.

from jewel.

rock3r avatar rock3r commented on May 28, 2024

Thanks for confirming!

from jewel.

mr-thierry avatar mr-thierry commented on May 28, 2024

You can look at how Package Search does it — their plugin works fine in Android Studio afaik.

I have download and ran the project. This project targets IntelliJ and not Android Studio. I does add a dependency to the Android Gradle plugin however. That may be enough for what I'm looking to do. Thanks for the suggestion!

from jewel.

rock3r avatar rock3r commented on May 28, 2024

Yeah, PKGS does target IJ but works fine in Studio (or used to! haven't checked in Studio in a while). They have the shadowing because the IJ platform at some point had a copy of Compose that was leaking, too, and that made it work, so I think it should indeed work for Studio until this is properly sorted

from jewel.

mr-thierry avatar mr-thierry commented on May 28, 2024

Do you have a link to the issue? Will +1 it 🙂

from jewel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.